Changes to default apps promo per ui leads:

Changes to default apps promo per ui leads:

1. Change hide message from 'Hide this message' to 'No thanks, hide this'.

2. Hide promo text when a default app is launched (this was already happening on uninstall).

3. Uninstall default apps when promo expires or is purposefully hidden.

4. Collapse apps section when promo expires or is purposefully hidden.

BUG=67292, 69268
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71100

[Erik does not do reviews, 2011-01-10 16:48:57]

LGTM

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/dom_ui/app_la...
File chrome/browser/dom_ui/app_launcher_handler.cc (right):

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/dom_ui/app_la...
chrome/browser/dom_ui/app_launcher_handler.cc:123: return false;
is there any legit way to hit this?  should this be NOTREACHED?

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/dom_ui/shown_...
File chrome/browser/dom_ui/shown_sections_handler.h (right):

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/dom_ui/shown_...
chrome/browser/dom_ui/shown_sections_handler.h:24: THUMB = 1 << 0,
THUMB is a weird name for most visited.  this threw me at first.  might be worth
changing.

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/extensions/de...
File chrome/browser/extensions/default_apps.cc (right):

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/extensions/de...
chrome/browser/extensions/default_apps.cc:120: SetPromoCounter(++promo_counter);
while you're in here, could you add a histogram value for AppsPromoHistogram for
PROMO_SEEN or something like that?

[Aaron Boodman, 2011-01-10 19:36:19]

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/dom_ui/app_la...
File chrome/browser/dom_ui/app_launcher_handler.cc (right):

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/dom_ui/app_la...
chrome/browser/dom_ui/app_launcher_handler.cc:123: return false;
On 2011/01/10 16:48:57, Erik Kay wrote:
> is there any legit way to hit this?  should this be NOTREACHED?

Yes, it is legit. We send every request for chrome://newtab/* through this
method. It returns true if it could handle it, false otherwise.

We do this to centralize knowledge about the form of the ping URLs in this
class.

I've added a clarifying comment.

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/dom_ui/shown_...
File chrome/browser/dom_ui/shown_sections_handler.h (right):

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/dom_ui/shown_...
chrome/browser/dom_ui/shown_sections_handler.h:24: THUMB = 1 << 0,
On 2011/01/10 16:48:57, Erik Kay wrote:
> THUMB is a weird name for most visited.  this threw me at first.  might be
worth
> changing.

Would require changing lots of JS too to match. I think it's out of scope for
this change.

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/extensions/de...
File chrome/browser/extensions/default_apps.cc (right):

http://codereview.chromium.org/6162006/diff/2001/chrome/browser/extensions/de...
chrome/browser/extensions/default_apps.cc:120: SetPromoCounter(++promo_counter);
On 2011/01/10 16:48:57, Erik Kay wrote:
> while you're in here, could you add a histogram value for AppsPromoHistogram
for
> PROMO_SEEN or something like that?

Done, can you check my changes to chrome/common/extension_constants.h? I'm not
sure if they're OK.

[Erik does not do reviews, 2011-01-10 20:03:30]

LGTM