Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/extensions/default_apps.h

Issue 6162006: Changes to default apps promo per ui leads: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/shown_sections_handler.cc ('k') | chrome/browser/extensions/default_apps.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/default_apps.h
diff --git a/chrome/browser/extensions/default_apps.h b/chrome/browser/extensions/default_apps.h
index a8b162c0021cc370f1388079338baeb8921c391f..2ff880135fdde6ef8232b856e76d674c39812029 100644
--- a/chrome/browser/extensions/default_apps.h
+++ b/chrome/browser/extensions/default_apps.h
@@ -19,7 +19,9 @@ class PrefService;
// - Whether to show the apps promo in the launcher
class DefaultApps {
public:
- // The maximum number of times to show the apps promo.
+ // The maximum number of times to show the apps promo. The promo counter
+ // actually goes up to this number + 1 because we need to differentiate
+ // between the first time we overflow and subsequent times.
static const int kAppsPromoCounterMax;
// Register our preferences.
@@ -42,15 +44,12 @@ class DefaultApps {
//
// NOTE: If the default apps have been installed, but |installed_ids| is
// different than GetDefaultApps(), this will permanently expire the promo.
- bool ShouldShowPromo(const ExtensionIdSet& installed_ids);
+ bool ShouldShowPromo(const ExtensionIdSet& installed_ids, bool* just_expired);
// Should be called after each app is installed. Once installed_ids contains
// all the default apps, GetAppsToInstall() will start returning NULL.
void DidInstallApp(const ExtensionIdSet& installed_ids);
- // Should be called after each time the promo is installed.
- void DidShowPromo();
-
// Force the promo to be hidden.
void SetPromoHidden();
« no previous file with comments | « chrome/browser/dom_ui/shown_sections_handler.cc ('k') | chrome/browser/extensions/default_apps.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698