chrome/browser/resources/ntp/apps.js - Issue 6162006: Changes to default apps promo per ui leads:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp/apps.js

Issue 6162006: Changes to default apps promo per ui leads: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/ntp/apps.js

diff --git a/chrome/browser/resources/ntp/apps.js b/chrome/browser/resources/ntp/apps.js

index 973dada98aa7cf6471ca28941ea4e50fcf9da0ca..4dd8bc12ce14a1589f4118fd95c06d46691860d4 100644

--- a/chrome/browser/resources/ntp/apps.js

+++ b/chrome/browser/resources/ntp/apps.js

@@ -78,7 +78,10 @@ function getAppsCallback(data) {

document.documentElement.classList.add('apps-promo-visible');

else

document.documentElement.classList.remove('apps-promo-visible');

- $('apps-promo-link').setAttribute('ping', appsPromoPing);

+ var appsPromoLink = $('apps-promo-link');

+ if (appsPromoLink)

+ appsPromoLink.setAttribute('ping', appsPromoPing);

maybeDoneLoading();

if (isDoneLoading()) {