Issue 6133001: Turn the volume range check into a bail out return to prevent browser crash....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6133001: Turn the volume range check into a bail out return to prevent browser crash.... (Closed)

Created:
9 years, 11 months ago by inferno

Modified:
9 years, 7 months ago

Reviewers:
fbarchard, fbarchard1

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Turn the volume range check into a bail out return to prevent browser crash. BUG=68244 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70635

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/renderer_host/audio_renderer_host.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download
	M	media/audio/audio_util.cc	View	1	2 chunks	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

fbarchard1

9 years, 11 months ago (2011-01-06 20:34:29 UTC) #1

LGTM w/ nit about (c)2011
I good change in my opinion, for release at least.

note that the code could potentially be useful with volumes out of range.
ie if volume < 0 set vol to 0
if volume > 1 actually do it properly, and clamp if necessary.
With float audio, you can potentially override speakers?
But especially with exceptionally quiet content it could be useful to push the
volume up.

http://codereview.chromium.org/6133001/diff/1002/chrome/browser/renderer_host...
File chrome/browser/renderer_host/audio_renderer_host.cc (right):

http://codereview.chromium.org/6133001/diff/1002/chrome/browser/renderer_host...
chrome/browser/renderer_host/audio_renderer_host.cc:1: // Copyright (c) 2010 The
Chromium Authors. All rights reserved.
update to 2011

http://codereview.chromium.org/6133001/diff/1002/media/audio/audio_util.cc
File media/audio/audio_util.cc (right):

http://codereview.chromium.org/6133001/diff/1002/media/audio/audio_util.cc#ne...
media/audio/audio_util.cc:1: // Copyright (c) 2010 The Chromium Authors. All
rights reserved.
update to 2011

Expand Messages | Collapse Messages