Turn the volume range check into a bail out return to prevent browser crash....

chrome/browser/renderer_host/audio_renderer_host.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

[fbarchard1, 2011/01/06 20:34:29]

update to 2011

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/audio_renderer_host.h"
 
 #include "base/metrics/histogram.h"
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "chrome/browser/renderer_host/audio_sync_reader.h"
 #include "chrome/common/render_messages.h"
@@ skipping 349 matching lines @@
                                     double volume) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   AudioEntry* entry = LookupById(msg.routing_id(), stream_id);
   if (!entry) {
     SendErrorMessage(msg.routing_id(), stream_id);
     return;
   }
 
   // Make sure the volume is valid.
-  CHECK(volume >= 0 && volume <= 1.0);
+  if (volume < 0 || volume > 1.0)
+      return;
   entry->controller->SetVolume(volume);
 }
 
 void AudioRendererHost::OnGetVolume(const IPC::Message& msg, int stream_id) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   NOTREACHED() << "This message shouldn't be received";
 }
 
 void AudioRendererHost::OnNotifyPacketReady(
     const IPC::Message& msg, int stream_id, uint32 packet_size) {
@@ skipping 88 matching lines @@
 
   // Iterate the map of entries.
   // TODO(hclam): Implement a faster look up method.
   for (AudioEntryMap::iterator i = audio_entries_.begin();
        i != audio_entries_.end(); ++i) {
     if (controller == i->second->controller.get())
       return i->second;
   }
   return NULL;
 }