chrome/browser/renderer_host/audio_renderer_host.cc - Issue 6133001: Turn the volume range check into a bail out return to prevent browser crash....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/audio_renderer_host.cc

Issue 6133001: Turn the volume range check into a bail out return to prevent browser crash.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/audio_renderer_host.cc

===================================================================

--- chrome/browser/renderer_host/audio_renderer_host.cc (revision 70339)

+++ chrome/browser/renderer_host/audio_renderer_host.cc (working copy)

@@ -368,7 +368,8 @@

}

// Make sure the volume is valid.

- CHECK(volume >= 0 && volume <= 1.0);

+ if (volume < 0 || volume > 1.0)

+ return;

entry->controller->SetVolume(volume);

}

« no previous file with comments | « no previous file | media/audio/audio_util.cc » ('j') | media/audio/audio_util.cc » ('J')