Issue 6119002: Make Page Action popup bubble anchor its arrow on the left for RTL languages....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6119002: Make Page Action popup bubble anchor its arrow on the left for RTL languages.... (Closed)

Created:
9 years, 11 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make Page Action popup bubble anchor its arrow on the left for RTL languages. BUG=68030 TEST=See bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70752

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/location_bar/page_action_image_view.cc	View		2 chunks	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

9 years, 11 months ago (2011-01-07 18:09:47 UTC) #2

lgtm

http://codereview.chromium.org/6119002/diff/1/chrome/browser/ui/views/locatio...
File chrome/browser/ui/views/location_bar/page_action_image_view.cc (right):

http://codereview.chromium.org/6119002/diff/1/chrome/browser/ui/views/locatio...
chrome/browser/ui/views/location_bar/page_action_image_view.cc:1: // Copyright
(c) 2011 The Chromium Authors. All rights reserved.
Happy New Year!

Expand Messages | Collapse Messages