 Chromium Code Reviews
 Chromium Code Reviews Issue 6119002:
  Make Page Action popup bubble anchor its arrow on the left for RTL languages....  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src/
    
  
    Issue 6119002:
  Make Page Action popup bubble anchor its arrow on the left for RTL languages....  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src/| Index: chrome/browser/ui/views/location_bar/page_action_image_view.cc | 
| =================================================================== | 
| --- chrome/browser/ui/views/location_bar/page_action_image_view.cc (revision 70726) | 
| +++ chrome/browser/ui/views/location_bar/page_action_image_view.cc (working copy) | 
| @@ -1,4 +1,4 @@ | 
| -// Copyright (c) 2010 The Chromium Authors. All rights reserved. | 
| +// Copyright (c) 2011 The Chromium Authors. All rights reserved. | 
| 
asargent_no_longer_on_chrome
2011/01/07 18:09:47
Happy New Year!
 | 
| // Use of this source code is governed by a BSD-style license that can be | 
| // found in the LICENSE file. | 
| @@ -83,13 +83,16 @@ | 
| View::ConvertPointToScreen(this, &origin); | 
| screen_bounds.set_origin(origin); | 
| + BubbleBorder::ArrowLocation arrow_location = base::i18n::IsRTL() ? | 
| + BubbleBorder::TOP_LEFT : BubbleBorder::TOP_RIGHT; | 
| + | 
| popup_ = ExtensionPopup::Show( | 
| page_action_->GetPopupUrl(current_tab_id_), | 
| browser, | 
| browser->profile(), | 
| browser->window()->GetNativeHandle(), | 
| screen_bounds, | 
| - BubbleBorder::TOP_RIGHT, | 
| + arrow_location, | 
| true, // Activate the popup window. | 
| inspect_with_devtools, | 
| ExtensionPopup::BUBBLE_CHROME, |