Make Page Action popup bubble anchor its arrow on the left for RTL languages....

chrome/browser/ui/views/location_bar/page_action_image_view.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.

[asargent_no_longer_on_chrome, 2011/01/07 18:09:47]

Happy New Year!

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/location_bar/page_action_image_view.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/extensions/extension_browser_event_router.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 64 matching lines @@
 
     // If we were already showing, then treat this click as a dismiss.
     if (popup_showing)
       return;
 
     gfx::Rect screen_bounds(GetImageBounds());
     gfx::Point origin(screen_bounds.origin());
     View::ConvertPointToScreen(this, &origin);
     screen_bounds.set_origin(origin);
 
+    BubbleBorder::ArrowLocation arrow_location = base::i18n::IsRTL() ?
+        BubbleBorder::TOP_LEFT : BubbleBorder::TOP_RIGHT;
+
     popup_ = ExtensionPopup::Show(
         page_action_->GetPopupUrl(current_tab_id_),
         browser,
         browser->profile(),
         browser->window()->GetNativeHandle(),
         screen_bounds,
-        BubbleBorder::TOP_RIGHT,
+        arrow_location,
         true,  // Activate the popup window.
         inspect_with_devtools,
         ExtensionPopup::BUBBLE_CHROME,
         this);  // ExtensionPopup::Observer
   } else {
     ExtensionBrowserEventRouter::GetInstance()->PageActionExecuted(
         profile_, page_action_->extension_id(), page_action_->id(),
         current_tab_id_, current_url_.spec(), button);
   }
 }
@@ skipping 131 matching lines @@
 void PageActionImageView::ExtensionPopupIsClosing(ExtensionPopup* popup) {
   DCHECK_EQ(popup_, popup);
   // ExtensionPopup is ref-counted, so we don't need to delete it.
   popup_ = NULL;
 }
 
 void PageActionImageView::HidePopup() {
   if (popup_)
     popup_->Close();
 }