Issue 6110006: give tabbed options clear browsing dialog a facelift

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6110006: give tabbed options clear browsing dialog a facelift (Closed)

Created:
9 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

give tabbed options clear browsing dialog a facelift It should now match the mocks modulo the adobe flash settings link (not sure why the mocks show it as a checkbox; AFAIK making it a checkbox is outside our ability to do). also make it work (the time period select dropdown was broken). BUG=69163, 63843 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71090

Patch Set 1 #

Patch Set 2 : rename #

Patch Set 3 : delete bugs #

Created: 9 years, 11 months ago

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -99 lines)
M	chrome/app/generated_resources.grd	View	2 chunks	+10 lines, -7 lines	0 comments
M	chrome/browser/dom_ui/options/clear_browser_data_handler.cc	View	2 chunks	+4 lines, -4 lines	0 comments
M	chrome/browser/resources/options/advanced_options.js	View	1 chunk	+1 line, -1 line	0 comments
A +	chrome/browser/resources/options/clear_browser_data.css	View	2 chunks	+4 lines, -4 lines	0 comments
A	chrome/browser/resources/options/clear_browser_data.html	View	1 chunk	+53 lines, -0 lines	0 comments
A +	chrome/browser/resources/options/clear_browser_data.js	View	5 chunks	+16 lines, -14 lines	0 comments
M	chrome/browser/resources/options/clear_browser_data_overlay.html	View	1 chunk	+0 lines, -62 lines	0 comments
M	chrome/browser/resources/options/options.html	View	4 chunks	+3 lines, -3 lines	0 comments
M	chrome/browser/resources/options/options.js	View	3 chunks	+4 lines, -3 lines	0 comments
M	chrome/browser/resources/options/pref_ui.js	View	2 chunks	+4 lines, -1 line	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

Followup suggestion: update the copyright year for files that have them.

9 years, 11 months ago (2011-01-11 21:26:22 UTC) #3

done

Expand Messages | Collapse Messages