Issue 6103003: Remove auth token generation timing histograms....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6103003: Remove auth token generation timing histograms.... (Closed)

Created:
9 years, 11 months ago by cbentzel

Modified:
9 years, 7 months ago

Reviewers:
wtc, asanka (google)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove auth token generation timing histograms. These didn't turn out to be terribly useful, and add some complexity to HttpAuthHandler. BUG=NONE TEST=targets build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70740

Patch Set 1 #

Patch Set 2 : Remove #include histogram #

Patch Set 3 : Remove #include time from header #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -29 lines)			Patch
	M	net/http/http_auth_handler.h	View	1 2	2 chunks	+0 lines, -9 lines	0 comments	Download
	M	net/http/http_auth_handler.cc	View	1	5 chunks	+0 lines, -20 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

9 years, 11 months ago (2011-01-11 20:33:10 UTC) #4

LGTM.

http://codereview.chromium.org/6103003/diff/9001/net/http/http_auth_handler.cc
File net/http/http_auth_handler.cc (right):

http://codereview.chromium.org/6103003/diff/9001/net/http/http_auth_handler.c...
net/http/http_auth_handler.cc:9: #include "base/stringprintf.h"
Nit: I suspect we can remove "base/stringprintf.h" now
because the base::StringPrintf call is gone.

Probably "base/string_util.h" also.

Expand Messages | Collapse Messages