Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Unified Diff: net/http/http_auth_handler.cc

Issue 6103003: Remove auth token generation timing histograms.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove #include time from header Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler.cc
===================================================================
--- net/http/http_auth_handler.cc (revision 70507)
+++ net/http/http_auth_handler.cc (working copy)
@@ -5,7 +5,6 @@
#include "net/http/http_auth_handler.h"
#include "base/logging.h"
-#include "base/metrics/histogram.h"
#include "base/string_util.h"
#include "base/stringprintf.h"
wtc 2011/01/11 20:33:10 Nit: I suspect we can remove "base/stringprintf.h"
#include "net/base/net_errors.h"
@@ -26,12 +25,6 @@
HttpAuthHandler::~HttpAuthHandler() {
}
-//static
-std::string HttpAuthHandler::GenerateHistogramNameFromScheme(
- const std::string& scheme) {
- return base::StringPrintf("Net.AuthGenerateToken_%s", scheme.c_str());
-}
-
bool HttpAuthHandler::InitFromChallenge(
HttpAuth::ChallengeTokenizer* challenge,
HttpAuth::Target target,
@@ -53,13 +46,6 @@
DCHECK(!ok || properties_ != -1);
DCHECK(!ok || auth_scheme_ != AUTH_SCHEME_MAX);
- if (ok)
- histogram_ = base::Histogram::FactoryTimeGet(
- GenerateHistogramNameFromScheme(scheme()),
- base::TimeDelta::FromMilliseconds(1),
- base::TimeDelta::FromSeconds(10), 50,
- base::Histogram::kUmaTargetedHistogramFlag);
-
return ok;
}
@@ -90,10 +76,8 @@
DCHECK(username != NULL || AllowsDefaultCredentials());
DCHECK(auth_token != NULL);
DCHECK(original_callback_ == NULL);
- DCHECK(histogram_.get());
original_callback_ = callback;
net_log_.BeginEvent(EventTypeFromAuthTarget(target_), NULL);
- generate_auth_token_start_ = base::TimeTicks::Now();
int rv = GenerateAuthTokenImpl(username, password, request,
&wrapper_callback_, auth_token);
if (rv != ERR_IO_PENDING)
@@ -118,10 +102,6 @@
void HttpAuthHandler::FinishGenerateAuthToken() {
// TOOD(cbentzel): Should this be done in OK case only?
- DCHECK(histogram_.get());
- base::TimeDelta generate_auth_token_duration =
- base::TimeTicks::Now() - generate_auth_token_start_;
- histogram_->AddTime(generate_auth_token_duration);
net_log_.EndEvent(EventTypeFromAuthTarget(target_), NULL);
original_callback_ = NULL;
}
« no previous file with comments | « net/http/http_auth_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698