Remove auth token generation timing histograms....

net/http/http_auth_handler.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_auth_handler.h"
 
 #include "base/logging.h"
-#include "base/metrics/histogram.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"

[wtc, 2011/01/11 20:33:10]

Nit: I suspect we can remove "base/stringprintf.h" now
because the base::StringPrintf call is gone.

Probably "base/string_util.h" also.

 #include "net/base/net_errors.h"
 
 namespace net {
 
 HttpAuthHandler::HttpAuthHandler()
     : auth_scheme_(AUTH_SCHEME_MAX),
       score_(-1),
       target_(HttpAuth::AUTH_NONE),
       properties_(-1),
       original_callback_(NULL),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           wrapper_callback_(
               this, &HttpAuthHandler::OnGenerateAuthTokenComplete)) {
 }
 
 HttpAuthHandler::~HttpAuthHandler() {
 }
 
-//static
-std::string HttpAuthHandler::GenerateHistogramNameFromScheme(
-    const std::string& scheme) {
-  return base::StringPrintf("Net.AuthGenerateToken_%s", scheme.c_str());
-}
-
 bool HttpAuthHandler::InitFromChallenge(
     HttpAuth::ChallengeTokenizer* challenge,
     HttpAuth::Target target,
     const GURL& origin,
     const BoundNetLog& net_log) {
   origin_ = origin;
   target_ = target;
   score_ = -1;
   properties_ = -1;
   net_log_ = net_log;
 
   auth_challenge_ = challenge->challenge_text();
   bool ok = Init(challenge);
 
   // Init() is expected to set the scheme, realm, score, and properties.  The
   // realm may be empty.
   DCHECK(!ok || !scheme().empty());
   DCHECK(!ok || score_ != -1);
   DCHECK(!ok || properties_ != -1);
   DCHECK(!ok || auth_scheme_ != AUTH_SCHEME_MAX);
 
-  if (ok)
-    histogram_ = base::Histogram::FactoryTimeGet(
-        GenerateHistogramNameFromScheme(scheme()),
-        base::TimeDelta::FromMilliseconds(1),
-        base::TimeDelta::FromSeconds(10), 50,
-        base::Histogram::kUmaTargetedHistogramFlag);
-
   return ok;
 }
 
 namespace {
 
 NetLog::EventType EventTypeFromAuthTarget(HttpAuth::Target target) {
   switch (target) {
     case HttpAuth::AUTH_PROXY:
       return NetLog::TYPE_AUTH_PROXY;
     case HttpAuth::AUTH_SERVER:
@@ skipping 10 matching lines @@
                                        const string16* password,
                                        const HttpRequestInfo* request,
                                        CompletionCallback* callback,
                                        std::string* auth_token) {
   // TODO(cbentzel): Enforce non-NULL callback after cleaning up SocketStream.
   DCHECK(request);
   DCHECK((username == NULL) == (password == NULL));
   DCHECK(username != NULL || AllowsDefaultCredentials());
   DCHECK(auth_token != NULL);
   DCHECK(original_callback_ == NULL);
-  DCHECK(histogram_.get());
   original_callback_ = callback;
   net_log_.BeginEvent(EventTypeFromAuthTarget(target_), NULL);
-  generate_auth_token_start_ =  base::TimeTicks::Now();
   int rv = GenerateAuthTokenImpl(username, password, request,
                                  &wrapper_callback_, auth_token);
   if (rv != ERR_IO_PENDING)
     FinishGenerateAuthToken();
   return rv;
 }
 
 bool HttpAuthHandler::NeedsIdentity() {
   return true;
 }
 
 bool HttpAuthHandler::AllowsDefaultCredentials() {
   return false;
 }
 
 void HttpAuthHandler::OnGenerateAuthTokenComplete(int rv) {
   CompletionCallback* callback = original_callback_;
   FinishGenerateAuthToken();
   if (callback)
     callback->Run(rv);
 }
 
 void HttpAuthHandler::FinishGenerateAuthToken() {
   // TOOD(cbentzel): Should this be done in OK case only?
-  DCHECK(histogram_.get());
-  base::TimeDelta generate_auth_token_duration =
-      base::TimeTicks::Now() - generate_auth_token_start_;
-  histogram_->AddTime(generate_auth_token_duration);
   net_log_.EndEvent(EventTypeFromAuthTarget(target_), NULL);
   original_callback_ = NULL;
 }
 
 }  // namespace net