Move Autotest to /usr/local/autotest and fix hard-coded autodir paths in client tests.

Move Autotest to /usr/local/autotest and fix hard-coded autodir paths in client tests.

Apologies for the wide distribution, but I wanted to make sure anyone whose test will be changing is notified. At the very least so everyone knows about self.autodir in the future :) Please look at your test and comment if you see something wrong. It's possible some of these tests are deprecated, but I've changed them all just in case.

Owners (from git blame):
  - tbroch: hardware_DeveloperRecovery
  - kmixter: logging_LogVolume, logging_UserCrash
  - jimhebert: platform_StackProtector, security_SuidBinaries
  - bleung: power_LoadTest/external_extensions.json
  - zhurunz: realtimecomm_GTalk*

Due to /home going no-exec plus mount, boot, and shell issues when using /mnt/stateful_partition/autotest pointing to /home/autotest... Autotest needs a new home. Since our test images already mount and unmount /usr/local properly, we've decided to settle there. 

With our relocation, several tests were discovered to have hard-coded the autodir path. Where possible, I've changed the hard-coded paths to use self.autodir. For others, I've merely updated the hard-coded value.

Notes:
  - hardware_DeveloperRecovery/src/DevRecTest.py is not an Autotest test case, so it can't use self.autodir without a larger refactoring.
  - logging_LogVolume/stateful_whitelist.txt already includes /usr/local as an ignored path. Only change was to remove stale paths.
  - power_LoadTest/external_extensions.json is not a python class, so it can't use self.autodir without a larger refactoring.
  - security_SuidBinaries already ignores /usr/local. So I just removed the stale path.

Change-Id: Ia0fee59b82fa9a9b1cf4e237d38007281aa5992e

BUG=chromium-os:10799
TEST=Will test in production. Will also run each test individually to make sure it passes (or at the least fails like it used to).

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c1c1539

[jimhebert, 2011-01-05 01:54:07]

The platform_StackProtector and security_SuidBinaries changes LGTM, thanks for
handling this.

[tbroch1, 2011-01-05 19:42:56]

DevRecTest.py, LGTM

thanks Dale.
On 2011/01/05 01:54:07, jimhebert wrote:
> The platform_StackProtector and security_SuidBinaries changes LGTM, thanks for
> handling this.

[zhurunz, 2011-01-05 20:10:01]

LGTM with realtimecomm
Thanks for clean up.
-- Zhurun

On Wed, Jan 5, 2011 at 11:42 AM, <tbroch@chromium.org> wrote:

> DevRecTest.py, LGTM
>
> thanks Dale.
>
> On 2011/01/05 01:54:07, jimhebert wrote:
>
>> The platform_StackProtector and security_SuidBinaries changes LGTM, thanks
>> for
>> handling this.
>>
>
>
>
> http://codereview.chromium.org/6090004/
>

[ericli, 2011-01-05 22:12:01]

LGTM.

On 2011/01/05 20:10:01, zhurunz wrote:
> LGTM with realtimecomm
> Thanks for clean up.
> -- Zhurun
> 
> On Wed, Jan 5, 2011 at 11:42 AM, <mailto:tbroch@chromium.org> wrote:
> 
> > DevRecTest.py, LGTM
> >
> > thanks Dale.
> >
> > On 2011/01/05 01:54:07, jimhebert wrote:
> >
> >> The platform_StackProtector and security_SuidBinaries changes LGTM, thanks
> >> for
> >> handling this.
> >>
> >
> >
> >
> > http://codereview.chromium.org/6090004/
> >

[Benson Leung, 2011-01-05 23:13:13]

http://codereview.chromium.org/6090004/diff/7001/client/site_tests/power_Load...
File client/site_tests/power_LoadTest/external_extensions.json (right):

http://codereview.chromium.org/6090004/diff/7001/client/site_tests/power_Load...
client/site_tests/power_LoadTest/external_extensions.json:3: "external_crx":
"/usr/local/autotest/tests/power_LoadTest/extension.crx",
Make sure to change 750enableExternalExtensions modfortest script. That has this
path hard coded as well.

[DaleCurtis, 2011-01-05 23:22:43]

http://codereview.chromium.org/6090004/diff/7001/client/site_tests/power_Load...
File client/site_tests/power_LoadTest/external_extensions.json (right):

http://codereview.chromium.org/6090004/diff/7001/client/site_tests/power_Load...
client/site_tests/power_LoadTest/external_extensions.json:3: "external_crx":
"/usr/local/autotest/tests/power_LoadTest/extension.crx",
Done.

http://codereview.chromium.org/5972012/

On 2011/01/05 23:13:13, Benson Leung wrote:
> Make sure to change 750enableExternalExtensions modfortest script. That has
this
> path hard coded as well.

[Benson Leung, 2011-01-07 01:13:07]

On 2011/01/05 23:22:43, dalec wrote:
>
http://codereview.chromium.org/6090004/diff/7001/client/site_tests/power_Load...
> File client/site_tests/power_LoadTest/external_extensions.json (right):
> 
>
http://codereview.chromium.org/6090004/diff/7001/client/site_tests/power_Load...
> client/site_tests/power_LoadTest/external_extensions.json:3: "external_crx":
> "/usr/local/autotest/tests/power_LoadTest/extension.crx",
> Done.
> 
> http://codereview.chromium.org/5972012/
> 
> On 2011/01/05 23:13:13, Benson Leung wrote:
> > Make sure to change 750enableExternalExtensions modfortest script. That has
> this
> > path hard coded as well.

LGTM.

[kmixter1, 2011-01-07 01:30:04]

http://codereview.chromium.org/6090004/diff/7001/client/site_tests/logging_Us...
File client/site_tests/logging_UserCrash/logging_UserCrash.py (right):

http://codereview.chromium.org/6090004/diff/7001/client/site_tests/logging_Us...
client/site_tests/logging_UserCrash/logging_UserCrash.py:587:
os.path.join(self.autodir, 'tests/crash_log_recursion_test')):
This isn't the right change.  There is in the base image
/etc/crash_reporter_logs.conf in the rootfs which itself hardcodes
/home/autotest/tests/crash_log_recursion_test.  If that path doesn't exist, the
recursion doesn't happen and the test tests nothing.  Can we create a
/home/autotest symlink to self.autodir?

[DaleCurtis, 2011-01-07 01:48:57]

http://codereview.chromium.org/6090004/diff/7001/client/site_tests/logging_Us...
File client/site_tests/logging_UserCrash/logging_UserCrash.py (right):

http://codereview.chromium.org/6090004/diff/7001/client/site_tests/logging_Us...
client/site_tests/logging_UserCrash/logging_UserCrash.py:587:
os.path.join(self.autodir, 'tests/crash_log_recursion_test')):
Symlink seems dirty. I fixed path in .conf file instead, 

http://codereview.chromium.org/5964016/

On 2011/01/07 01:30:04, kmixter1 wrote:
> This isn't the right change.  There is in the base image
> /etc/crash_reporter_logs.conf in the rootfs which itself hardcodes
> /home/autotest/tests/crash_log_recursion_test.  If that path doesn't exist,
the
> recursion doesn't happen and the test tests nothing.  Can we create a
> /home/autotest symlink to self.autodir?

[kmixter1, 2011-01-07 03:14:23]

LGTM on the LogVolume and UserCrash test changes