Move Autotest to /usr/local/autotest and fix hard-coded autodir paths in client tests.

client/site_tests/logging_UserCrash/logging_UserCrash.py

 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import grp, logging, os, pwd, re, stat, subprocess
 from signal import SIGSEGV
 from autotest_lib.client.bin import site_crash_test, test, utils
 from autotest_lib.client.common_lib import error
 
 _COLLECTION_ERROR_SIGNATURE = 'crash_reporter-user-collection'
@@ skipping 566 matching lines @@
         if not ('log=' + result['log']) in utils.read_file(result['meta']):
             raise error.TestFail('Meta file does not reference log')
 
 
     def _test_crash_log_infinite_recursion(self):
         recursion_triggering_crasher = os.path.join(
             os.path.dirname(self.bindir), 'crash_log_recursion_test')
         # The configuration file hardcodes this path, so make sure it's still
         # the same.
         if (recursion_triggering_crasher !=
-            '/home/autotest/tests/crash_log_recursion_test'):
+            os.path.join(self.autodir, 'tests/crash_log_recursion_test')):

[kmixter1, 2011/01/07 01:30:04]

This isn't the right change.  There is in the base image
/etc/crash_reporter_logs.conf in the rootfs which itself hardcodes
/home/autotest/tests/crash_log_recursion_test.  If that path doesn't exist, the
recursion doesn't happen and the test tests nothing.  Can we create a
/home/autotest symlink to self.autodir?

[DaleCurtis, 2011/01/07 01:48:57]

Symlink seems dirty. I fixed path in .conf file instead, 

http://codereview.chromium.org/5964016/

On 2011/01/07 01:30:04, kmixter1 wrote:

           raise error.TestError('Path to recursion test changed')
         # Copy crasher_path to a test location with correct mode and a
         # special name to trigger crash log creation.
         utils.system('cp -a "%s" "%s"' % (self._crasher_path,
                                           recursion_triggering_crasher))
         # Simply completing this command means that we avoided
         # infinite recursion.
         result = self._run_crasher_process(
             'root', crasher_path=recursion_triggering_crasher)
 
@@ skipping 73 matching lines @@
                               'root_crasher_no_consent',
                               'crash_filtering',
                               'max_enqueued_crashes',
                               'core2md_failure',
                               'internal_directory_failure',
                               'crash_logs_creation',
                               'crash_log_infinite_recursion',
                               'core_file_persists_in_debug',
                               'core_file_removed_in_production'],
                               initialize_crash_reporter = True)