Enable passing of script data via script creation methods

Allow passing of script data via script creation methods (Script::New & Script::Compile), 
so that this field may be used to pass some data to compile events.

[caseq, 2010-02-15 19:22:58]

Hi Søren!

Pavel mentioned you're the best person to review this :)
Basically, we'd like to be able to set script data early, so that these are
already available in AfterCompile event -- so I'm adding another parameter to
Script::Compile & Script::Compile which is called persistent_data (to
distinguish it from another existent parameter, pre_data, that is not stored
along with compiled script).

[Søren Thygesen Gjesse, 2010-02-16 10:37:53]

LGTM with comments addressed.

http://codereview.chromium.org/606053/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/606053/diff/1/2#newcode543
include/v8.h:543: * will use the currently entered context.
Please add a comment saying the the script_data argument has the same effect as
calling SetData on the script afterwards, except that it will be set earlier in
the life-cycle for the script.

Some explanation of the ScriptData class and the argument name pre_data could
come in handy as well.

http://codereview.chromium.org/606053/diff/1/2#newcode548
include/v8.h:548: Handle<String> persistent_data = Handle<String>());
Please rename the argument to script_data.

http://codereview.chromium.org/606053/diff/1/2#newcode572
include/v8.h:572: Handle<String> persistent_data =
Ditto.

http://codereview.chromium.org/606053/diff/1/2#newcode585
include/v8.h:585: Handle<String> persistent_data =
Ditto.

http://codereview.chromium.org/606053/diff/1/3
File src/api.cc (right):

http://codereview.chromium.org/606053/diff/1/3#newcode1109
src/api.cc:1109: v8::ScriptData* script_data,
script_data -> pre_data (one place below as well)

http://codereview.chromium.org/606053/diff/1/3#newcode1110
src/api.cc:1110: v8::Handle<String> persistent_data) {
persistent_data -> script_data (two places below as well)

http://codereview.chromium.org/606053/diff/1/4
File src/compiler.cc (right):

http://codereview.chromium.org/606053/diff/1/4#newcode281
src/compiler.cc:281: if (!script_data.is_null()) {
Just drop the if here and pass in undefined when no script data is set.

http://codereview.chromium.org/606053/diff/1/5
File src/compiler.h (right):

http://codereview.chromium.org/606053/diff/1/5#newcode98
src/compiler.h:98: Handle<Object> script_data =
Please make this argument value explicit.

http://codereview.chromium.org/606053/diff/1/6
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/606053/diff/1/6#newcode663
test/cctest/test-debug.cc:663: argc, argv);
Indention.

http://codereview.chromium.org/606053/diff/1/6#newcode5307
test/cctest/test-debug.cc:5307: v8::Script::Compile(script, &origin2, NULL,
v8::String::New("in compile"));
4-space indent.

[caseq, 2010-02-16 15:00:47]

http://codereview.chromium.org/606053/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/606053/diff/1/2#newcode543
include/v8.h:543: * will use the currently entered context.
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> Please add a comment saying the the script_data argument has the same effect
as
> calling SetData on the script afterwards, except that it will be set earlier
in
> the life-cycle for the script.
> 
> Some explanation of the ScriptData class and the argument name pre_data could
> come in handy as well.

Done.

http://codereview.chromium.org/606053/diff/1/2#newcode548
include/v8.h:548: Handle<String> persistent_data = Handle<String>());
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> Please rename the argument to script_data.

Done.

http://codereview.chromium.org/606053/diff/1/2#newcode572
include/v8.h:572: Handle<String> persistent_data =
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> Ditto.

Done.

http://codereview.chromium.org/606053/diff/1/2#newcode585
include/v8.h:585: Handle<String> persistent_data =
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> Ditto.

Done.

http://codereview.chromium.org/606053/diff/1/3
File src/api.cc (right):

http://codereview.chromium.org/606053/diff/1/3#newcode1109
src/api.cc:1109: v8::ScriptData* script_data,
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> script_data -> pre_data (one place below as well)

Done.

http://codereview.chromium.org/606053/diff/1/3#newcode1110
src/api.cc:1110: v8::Handle<String> persistent_data) {
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> persistent_data -> script_data (two places below as well)

Done.

http://codereview.chromium.org/606053/diff/1/4
File src/compiler.cc (right):

http://codereview.chromium.org/606053/diff/1/4#newcode281
src/compiler.cc:281: if (!script_data.is_null()) {
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> Just drop the if here and pass in undefined when no script data is set.

Done.

http://codereview.chromium.org/606053/diff/1/5
File src/compiler.h (right):

http://codereview.chromium.org/606053/diff/1/5#newcode98
src/compiler.h:98: Handle<Object> script_data =
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> Please make this argument value explicit.

Done.

http://codereview.chromium.org/606053/diff/1/6
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/606053/diff/1/6#newcode663
test/cctest/test-debug.cc:663: argc, argv);
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> Indention.

Done.

http://codereview.chromium.org/606053/diff/1/6#newcode5307
test/cctest/test-debug.cc:5307: v8::Script::Compile(script, &origin2, NULL,
v8::String::New("in compile"));
On 2010/02/16 10:37:55, Søren Gjesse wrote:
> 4-space indent.

Done.

[caseq, 2010-02-16 15:23:04]

Oops. Added newly changed files.

[Søren Thygesen Gjesse, 2010-02-16 15:59:23]

LGTM