Issue 6047008: Added ppapi::Surface3D. This CL completes the new Pepper3D interface. The imp...

Issue 6047008: Added ppapi::Surface3D. This CL completes the new Pepper3D interface. The imp... (Closed)

Created:
10 years ago by alokp

Modified:
9 years, 6 months ago

Reviewers:
brettw, apatrick

CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Added ppapi::Surface3D. This CL completes the new Pepper3D interface. The implementation is still incomplete but all gpu demos still work! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70229

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+522 lines, -146 lines)			Patch
M	gpu/demos/framework/pepper.cc	View	4 chunks	+10 lines, -4 lines	0 comments	Download
M	ppapi/c/dev/ppb_context_3d_dev.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
A	ppapi/c/dev/ppb_surface_3d_dev.h	View	1 chunk	+111 lines, -0 lines	0 comments	Download
M	ppapi/cpp/dev/context_3d_dev.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/cpp/dev/context_3d_dev.cc	View	4 chunks	+6 lines, -12 lines	0 comments	Download
A	ppapi/cpp/dev/surface_3d_dev.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	ppapi/cpp/dev/surface_3d_dev.cc	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	ppapi/cpp/instance.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/cpp/instance.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/ppapi.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	ppapi/tests/all_c_includes.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/tests/all_cpp_includes.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/plugin_module.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	6 chunks	+11 lines, -19 lines	2 comments	Download
M	webkit/plugins/ppapi/ppb_context_3d_impl.h	View	4 chunks	+15 lines, -27 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_context_3d_impl.cc	View	6 chunks	+48 lines, -67 lines	0 comments	Download
A	webkit/plugins/ppapi/ppb_surface_3d_impl.h	View	1 chunk	+71 lines, -0 lines	0 comments	Download
A	webkit/plugins/ppapi/ppb_surface_3d_impl.cc	View	1 chunk	+139 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/resource.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

alokp

http://codereview.chromium.org/6047008/diff/1/webkit/plugins/ppapi/ppapi_plugin_instance.cc File webkit/plugins/ppapi/ppapi_plugin_instance.cc (right): http://codereview.chromium.org/6047008/diff/1/webkit/plugins/ppapi/ppapi_plugin_instance.cc#newcode426 webkit/plugins/ppapi/ppapi_plugin_instance.cc:426: bool PluginInstance::BindGraphics(PP_Resource graphics_id) { I think there is redundancy ...

10 years ago (2010-12-23 22:07:54 UTC) #1

You're on fire Dude. Do what you need. LGTM.

Expand Messages | Collapse Messages