Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: webkit/plugins/ppapi/ppb_surface_3d_impl.cc

Issue 6047008: Added ppapi::Surface3D. This CL completes the new Pepper3D interface. The imp... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppb_surface_3d_impl.cc
===================================================================
--- webkit/plugins/ppapi/ppb_surface_3d_impl.cc (revision 0)
+++ webkit/plugins/ppapi/ppb_surface_3d_impl.cc (revision 0)
@@ -0,0 +1,139 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/plugins/ppapi/ppb_surface_3d_impl.h"
+
+#include "gpu/command_buffer/common/command_buffer.h"
+#include "ppapi/c/dev/ppb_graphics_3d_dev.h"
+#include "webkit/plugins/ppapi/common.h"
+#include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
+
+namespace webkit {
+namespace ppapi {
+
+namespace {
+
+PP_Resource Create(PP_Instance instance_id,
+ PP_Config3D_Dev config,
+ const int32_t* attrib_list) {
+ PluginInstance* instance = ResourceTracker::Get()->GetInstance(instance_id);
+ if (!instance)
+ return 0;
+
+ scoped_refptr<PPB_Surface3D_Impl> surface(
+ new PPB_Surface3D_Impl(instance));
+ if (!surface->Init(config, attrib_list))
+ return 0;
+
+ return surface->GetReference();
+}
+
+PP_Bool IsSurface3D(PP_Resource resource) {
+ return BoolToPPBool(!!Resource::GetAs<PPB_Surface3D_Impl>(resource));
+}
+
+int32_t SetAttrib(PP_Resource surface_id,
+ int32_t attribute,
+ int32_t value) {
+ // TODO(alokp): Implement me.
+ return 0;
+}
+
+int32_t GetAttrib(PP_Resource surface_id,
+ int32_t attribute,
+ int32_t* value) {
+ // TODO(alokp): Implement me.
+ return 0;
+}
+
+int32_t SwapBuffers(PP_Resource surface_id,
+ PP_CompletionCallback callback) {
+ scoped_refptr<PPB_Surface3D_Impl> surface(
+ Resource::GetAs<PPB_Surface3D_Impl>(surface_id));
+ return surface->SwapBuffers();
+}
+
+const PPB_Surface3D_Dev ppb_surface3d = {
+ &Create,
+ &IsSurface3D,
+ &SetAttrib,
+ &GetAttrib,
+ &SwapBuffers
+};
+
+} // namespace
+
+PPB_Surface3D_Impl::PPB_Surface3D_Impl(PluginInstance* instance)
+ : Resource(instance->module()),
+ instance_(instance),
+ bound_to_instance_(false),
+ context_(NULL) {
+}
+
+PPB_Surface3D_Impl::~PPB_Surface3D_Impl() {
+}
+
+const PPB_Surface3D_Dev* PPB_Surface3D_Impl::GetInterface() {
+ return &ppb_surface3d;
+}
+
+PPB_Surface3D_Impl* PPB_Surface3D_Impl::AsPPB_Surface3D_Impl() {
+ return this;
+}
+
+bool PPB_Surface3D_Impl::Init(PP_Config3D_Dev config,
+ const int32_t* attrib_list) {
+ return true;
+}
+
+bool PPB_Surface3D_Impl::BindToInstance(bool bind) {
+ bound_to_instance_ = bind;
+ return true;
+}
+
+bool PPB_Surface3D_Impl::BindToContext(
+ PluginDelegate::PlatformContext3D* context) {
+ if (context == context_)
+ return true;
+
+ // Unbind from the current context.
+ if (context_) {
+ context_->SetSwapBuffersCallback(NULL);
+ }
+ if (context) {
+ // Resize the backing texture to the size of the instance when it is bound.
+ // TODO(alokp): This should be the responsibility of plugins.
+ context->ResizeBackingTexture(instance()->position().size());
+
+ // This is a temporary hack. The SwapBuffers is issued to force the resize
+ // to take place before any subsequent rendering. This might lead to a
+ // partially rendered frame being displayed. It is also not thread safe
+ // since the SwapBuffers is written to the command buffer and that command
+ // buffer might be written to by another thread.
+ // TODO(apatrick): Figure out the semantics of binding and resizing.
+ context->SwapBuffers();
+
+ context->SetSwapBuffersCallback(
+ NewCallback(this, &PPB_Surface3D_Impl::OnSwapBuffers));
+ }
+ context_ = context;
+ return true;
+}
+
+bool PPB_Surface3D_Impl::SwapBuffers() {
+ return context_ && context_->SwapBuffers();
+}
+
+unsigned int PPB_Surface3D_Impl::GetBackingTextureId() {
+ return context_ ? context_->GetBackingTextureId() : 0;
+}
+
+void PPB_Surface3D_Impl::OnSwapBuffers() {
+ if (bound_to_instance_)
+ instance()->CommitBackingTexture();
+}
+
+} // namespace ppapi
+} // namespace webkit
+
Property changes on: webkit\plugins\ppapi\ppb_surface_3d_impl.cc
___________________________________________________________________
Added: svn:eol-style
+ LF

Powered by Google App Engine
This is Rietveld 408576698