Issue 6035010: chromeos: Add metrics for various accelerators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6035010: chromeos: Add metrics for various accelerators. (Closed)

Created:
9 years, 12 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/ui/views/frame

Visibility:
Public.

Description

chromeos: Add metrics for various accelerators. This adds reporting of the accelerators used to invoke various actions (e.g. Back can be invoked by Alt-Left, Backspace, or F1 on Chrome OS). These stats will be used as input for future keyboard designs. Also removed the F5 "System options" accelerator, which is a no-op -- Chrome never sees this key since the window manager grabs it. BUG=chromium-os:10403 TEST=replaced the metrics calls with logging statements and checked that they were executed when expected Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70572

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -6 lines)			Patch
M	chrome/browser/chromeos/system_key_event_listener.cc	View	1 2 3 4	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/accelerator_table_gtk.cc	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3 4 5 6	4 chunks	+69 lines, -3 lines	0 comments	Download