Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2114)

Unified Diff: chrome/browser/chromeos/system_key_event_listener.cc

Issue 6035010: chromeos: Add metrics for various accelerators. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/ui/views/frame
Patch Set: fix bad merge Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/system_key_event_listener.cc
diff --git a/chrome/browser/chromeos/system_key_event_listener.cc b/chrome/browser/chromeos/system_key_event_listener.cc
index 2df12ddd711ec726ba89e1883cc2415bfb7f3635..8e5bd4155d6def408bb6efefede0634315518527 100644
--- a/chrome/browser/chromeos/system_key_event_listener.cc
+++ b/chrome/browser/chromeos/system_key_event_listener.cc
@@ -10,6 +10,7 @@
#include "chrome/browser/chromeos/audio_handler.h"
#include "chrome/browser/chromeos/brightness_bubble.h"
#include "chrome/browser/chromeos/volume_bubble.h"
+#include "chrome/browser/metrics/user_metrics.h"
#include "third_party/cros/chromeos_wm_ipc_enums.h"
namespace chromeos {
@@ -89,14 +90,20 @@ GdkFilterReturn SystemKeyEventListener::GdkEventFilter(GdkXEvent* gxevent,
if (!(xevent->xkey.state & (Mod1Mask | ShiftMask | ControlMask))) {
if ((keycode == listener->key_f8_) ||
(keycode == listener->key_volume_mute_)) {
+ if (keycode == listener->key_f8_)
+ UserMetrics::RecordAction(UserMetricsAction("Accel_VolumeMute_F8"));
listener->OnVolumeMute();
return GDK_FILTER_REMOVE;
} else if ((keycode == listener->key_f9_) ||
keycode == listener->key_volume_down_) {
+ if (keycode == listener->key_f9_)
+ UserMetrics::RecordAction(UserMetricsAction("Accel_VolumeDown_F9"));
listener->OnVolumeDown();
return GDK_FILTER_REMOVE;
} else if ((keycode == listener->key_f10_) ||
(keycode == listener->key_volume_up_)) {
+ if (keycode == listener->key_f10_)
+ UserMetrics::RecordAction(UserMetricsAction("Accel_VolumeUp_F10"));
listener->OnVolumeUp();
return GDK_FILTER_REMOVE;
}
« no previous file with comments | « no previous file | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698