Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 6035010: chromeos: Add metrics for various accelerators. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/ui/views/frame
Patch Set: fix bad merge Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 499
500 // Retrieves the command id for the specified Windows app command. 500 // Retrieves the command id for the specified Windows app command.
501 int GetCommandIDForAppCommandID(int app_command_id) const; 501 int GetCommandIDForAppCommandID(int app_command_id) const;
502 502
503 // Callback for the loading animation(s) associated with this view. 503 // Callback for the loading animation(s) associated with this view.
504 void LoadingAnimationCallback(); 504 void LoadingAnimationCallback();
505 505
506 // Initialize the hung plugin detector. 506 // Initialize the hung plugin detector.
507 void InitHangMonitor(); 507 void InitHangMonitor();
508 508
509 // Possibly records a user metrics action corresponding to the passed-in
510 // accelerator. Only implemented for Chrome OS, where we're interested in
511 // learning about how frequently the top-row keys are used.
512 void UpdateAcceleratorMetrics(const views::Accelerator& accelerator,
513 int command_id);
514
509 // Invoked from TabSelectedAt or when instant is made active. Is 515 // Invoked from TabSelectedAt or when instant is made active. Is
510 // |change_tab_contents| is true, |new_contents| is added to the view 516 // |change_tab_contents| is true, |new_contents| is added to the view
511 // hierarchy, if |change_tab_contents| is false, it's assumed |new_contents| 517 // hierarchy, if |change_tab_contents| is false, it's assumed |new_contents|
512 // has already been added to the view hierarchy. 518 // has already been added to the view hierarchy.
513 void ProcessTabSelected(TabContentsWrapper* new_contents, 519 void ProcessTabSelected(TabContentsWrapper* new_contents,
514 bool change_tab_contents); 520 bool change_tab_contents);
515 521
516 // Last focused view that issued a tab traversal. 522 // Last focused view that issued a tab traversal.
517 int last_focused_view_storage_id_; 523 int last_focused_view_storage_id_;
518 524
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
658 UnhandledKeyboardEventHandler unhandled_keyboard_event_handler_; 664 UnhandledKeyboardEventHandler unhandled_keyboard_event_handler_;
659 665
660 scoped_ptr<AccessibleViewHelper> accessible_view_helper_; 666 scoped_ptr<AccessibleViewHelper> accessible_view_helper_;
661 667
662 NotificationRegistrar registrar_; 668 NotificationRegistrar registrar_;
663 669
664 DISALLOW_COPY_AND_ASSIGN(BrowserView); 670 DISALLOW_COPY_AND_ASSIGN(BrowserView);
665 }; 671 };
666 672
667 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_ 673 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/accelerator_table_gtk.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698