Fixes bug in handling of openning background tabs by way of clicking

Fixes bug in handling of openning background tabs by way of clicking
on omnibox.

BUG=60553
TEST=see bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70616

[Peter Kasting, 2011-01-05 01:28:11]

LGTM

http://codereview.chromium.org/6028010/diff/1/chrome/browser/autocomplete/aut...
File chrome/browser/autocomplete/autocomplete_edit.h (right):

http://codereview.chromium.org/6028010/diff/1/chrome/browser/autocomplete/aut...
chrome/browser/autocomplete/autocomplete_edit.h:259: bool IsPopupOpen() const;
This makes me really sad.

We really need to make the location bar view own both the edit and the popup,
instead of having the edit own the popup, and stop plumbing everything through.

[sky, 2011-01-05 16:44:41]

On Tue, Jan 4, 2011 at 5:28 PM,  <pkasting@chromium.org> wrote:
> LGTM
>
>
>
http://codereview.chromium.org/6028010/diff/1/chrome/browser/autocomplete/aut...
> File chrome/browser/autocomplete/autocomplete_edit.h (right):
>
>
http://codereview.chromium.org/6028010/diff/1/chrome/browser/autocomplete/aut...
> chrome/browser/autocomplete/autocomplete_edit.h:259: bool IsPopupOpen()
> const;
> This makes me really sad.
>
> We really need to make the location bar view own both the edit and the
> popup, instead of having the edit own the popup, and stop plumbing
> everything through.

Instead of plumbing IsOpen through I can do:

location_entry_->popup_model()->IsOpen()

I didn't do that because of the comment above popup_model. Would you
prefer changing the comment and going this route?

  -Scott

[Peter Kasting, 2011-01-05 20:06:37]

On 2011/01/05 16:44:41, sky wrote:
> Instead of plumbing IsOpen through I can do:
> 
> location_entry_->popup_model()->IsOpen()
> 
> I didn't do that because of the comment above popup_model. Would you
> prefer changing the comment and going this route?

Maybe we should change the comment to "TODO: The edit and popup should be
siblings owned by the LocationBarView, making this accessor unnecessary" and
then go that route?

[sky, 2011-01-05 21:03:29]

Nuked IsPopupOpen and added TODO.

  -Scott