Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit.h

Issue 6028010: Fixes bug in handling of openning background tabs by way of clicking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nuke IsPopupOpen. Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_edit.h
diff --git a/chrome/browser/autocomplete/autocomplete_edit.h b/chrome/browser/autocomplete/autocomplete_edit.h
index da0625e64d30fa16e39f26ec07414e776d449136..1a8da22a65d901c16677806846e86f03802d62e9 100644
--- a/chrome/browser/autocomplete/autocomplete_edit.h
+++ b/chrome/browser/autocomplete/autocomplete_edit.h
@@ -44,6 +44,8 @@ class AutocompleteEditController {
gfx::NativeView view_gaining_focus) = 0;
// Sent prior to OnAutoCompleteAccept and before the model has been reverted.
+ // This is only invoked if the popup is closed before invoking
+ // OnAutoCompleteAccept.
virtual void OnAutocompleteWillAccept() = 0;
// Commits the suggested text. |typed_text| is the current text showing in the
@@ -138,7 +140,8 @@ class AutocompleteEditModel : public NotificationObserver {
void SetPopupModel(AutocompletePopupModel* popup_model);
- // It should only be used by testing code.
+ // TODO: The edit and popup should be siblings owned by the LocationBarView,
+ // making this accessor unnecessary.
AutocompletePopupModel* popup_model() const { return popup_; }
// Invoked when the profile has changed.
« no previous file with comments | « no previous file | chrome/browser/autocomplete/autocomplete_edit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698