Fixes bug in handling of openning background tabs by way of clicking

chrome/browser/autocomplete/autocomplete_edit.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_H_
 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_H_
 #pragma once
 
 #include "base/string16.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
@@ skipping 26 matching lines @@
  public:
   // Sent when the autocomplete popup is about to close.
   virtual void OnAutocompleteWillClosePopup() = 0;
 
   // Sent when the edit is losing focus. |view_gaining_focus| is the view
   // gaining focus and may be null.
   virtual void OnAutocompleteLosingFocus(
       gfx::NativeView view_gaining_focus) = 0;
 
   // Sent prior to OnAutoCompleteAccept and before the model has been reverted.
+  // This is only invoked if the popup is closed before invoking
+  // OnAutoCompleteAccept.
   virtual void OnAutocompleteWillAccept() = 0;
 
   // Commits the suggested text. |typed_text| is the current text showing in the
   // autocomplete. Returns true if the text was committed.
   virtual bool OnCommitSuggestedText(const std::wstring& typed_text) = 0;
 
   // Accepts the currently showing instant preview, if any, and returns true.
   // Returns false if there is no instant preview showing.
   virtual bool AcceptCurrentInstantPreview() = 0;
 
@@ skipping 189 matching lines @@
   // Asks the browser to load the item at |index|, with the given properties.
   void OpenURL(const GURL& url,
                WindowOpenDisposition disposition,
                PageTransition::Type transition,
                const GURL& alternate_nav_url,
                size_t index,
                const std::wstring& keyword);
 
   bool has_focus() const { return has_focus_; }
 
+  // Returns true if the popup is open.
+  bool IsPopupOpen() const;

[Peter Kasting, 2011/01/05 01:28:11]

This makes me really sad.

We really need to make the location bar view own both the edit and the popup,
instead of having the edit own the popup, and stop plumbing everything through.

+
   // Accessors for keyword-related state (see comments on keyword_ and
   // is_keyword_hint_).
   std::wstring keyword() const {
     return (is_keyword_hint_ || (keyword_ui_state_ != NO_KEYWORD)) ?
         keyword_ : std::wstring();
   }
   bool is_keyword_hint() const { return is_keyword_hint_; }
 
   // Accepts the current keyword hint as a keyword.
   void AcceptKeyword();
@@ skipping 228 matching lines @@
   mutable GURL paste_and_go_url_;
   mutable PageTransition::Type paste_and_go_transition_;
   mutable GURL paste_and_go_alternate_nav_url_;
 
   Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(AutocompleteEditModel);
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_EDIT_H_