Issue 6028005: Make CopyTexImage2D and CopyTexSubImage2D fail if...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6028005: Make CopyTexImage2D and CopyTexSubImage2D fail if... (Closed)

Created:
10 years ago by greggman

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make CopyTexImage2D and CopyTexSubImage2D fail if formats are incompatible. TEST=unit tests, more WebGL conformance tests pass. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70021

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+611 lines, -172 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1	4 chunks	+14 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.cc	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/framebuffer_manager.h	View	1	4 chunks	+27 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/service/framebuffer_manager.cc	View	1	3 chunks	+141 lines, -12 lines	0 comments	Download
M	gpu/command_buffer/service/framebuffer_manager_unittest.cc	View	1	6 chunks	+145 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	9 chunks	+87 lines, -101 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1	8 chunks	+59 lines, -33 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h	View	1	3 chunks	+15 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_autogen.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/renderbuffer_manager.h	View	1	3 chunks	+28 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/renderbuffer_manager_unittest.cc	View	1 2	2 chunks	+33 lines, -8 lines	0 comments	Download