Issue 6026010: Autofill heuristics regular expressions should be stored in external data files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6026010: Autofill heuristics regular expressions should be stored in external data files. (Closed)

Created:
10 years ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews, pam+watch_chromium.org, Ilya Sherman, Paweł Hajdan Jr., James Hawkins, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Autofill heuristics regular expressions should be stored in external data files. This change moves the Autofill heuristics regular expressions out to a new autofill_resources.grd file. This grd file is not meant to be localized. Eventually it will contain the locale-specific regular expressions as well as the English versions. This CL, however, just moves the English versions out of source. BUG=55787 TEST=FormStructureBrowserTest.HTMLFiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70535

Patch Set 1 #

Patch Set 2 : Nits #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -68 lines)			Patch
M	chrome/browser/autofill/address_field.cc	View	1	14 chunks	+36 lines, -26 lines	0 comments	Download
A	chrome/browser/autofill/autofill_resources.grd	View		1 chunk	+129 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/credit_card_field.cc	View	1	7 chunks	+11 lines, -8 lines	0 comments	Download
M	chrome/browser/autofill/form_field.cc	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/form_structure_browsertest.cc	View		2 chunks	+10 lines, -16 lines	0 comments	Download
M	chrome/browser/autofill/name_field.cc	View		5 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/autofill/phone_field.cc	View		4 chunks	+16 lines, -6 lines	0 comments	Download
M	chrome/chrome.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_dll.gypi	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		6 chunks	+8 lines, -2 lines	0 comments	Download
M	tools/grit/resource_ids	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages