chrome/chrome_dll.gypi - Issue 6026010: Autofill heuristics regular expressions should be stored in external data files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_dll.gypi

Issue 6026010: Autofill heuristics regular expressions should be stored in external data files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Nits Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_dll.gypi

diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi

index 267382fbed8199a527b330bba8e0ba36fafa5311..b45b3bd065f779b0785ce409dc0c7a22e8f826bf 100644

--- a/chrome/chrome_dll.gypi

+++ b/chrome/chrome_dll.gypi

@@ -111,6 +111,7 @@

# but that causes errors in other targets when

# resulting .res files get referenced multiple times.

'<(SHARED_INTERMEDIATE_DIR)/app/app_resources/app_resources.rc',

+ '<(SHARED_INTERMEDIATE_DIR)/chrome/autofill_resources.rc',

'<(SHARED_INTERMEDIATE_DIR)/chrome/browser_resources.rc',

'<(SHARED_INTERMEDIATE_DIR)/chrome/common_resources.rc',

'<(SHARED_INTERMEDIATE_DIR)/chrome/renderer_resources.rc',

@@ -326,6 +327,7 @@

'action_name': 'repack_chrome',

'variables': {

'pak_inputs': [

+ '<(grit_out_dir)/autofill_resources.pak',

'<(grit_out_dir)/browser_resources.pak',

'<(grit_out_dir)/common_resources.pak',

'<(grit_out_dir)/default_plugin_resources/default_plugin_resources.pak',

@@ -582,6 +584,7 @@

# but that causes errors in other targets when

# resulting .res files get referenced multiple times.

'<(SHARED_INTERMEDIATE_DIR)/app/app_resources/app_resources.rc',

+ '<(SHARED_INTERMEDIATE_DIR)/chrome/autofill_resources.rc',

'<(SHARED_INTERMEDIATE_DIR)/chrome/common_resources.rc',

# TODO(sgk): left-over from pre-gyp build, figure out

« no previous file with comments | « chrome/chrome.gyp ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »