Autofill heuristics regular expressions should be stored in external data files.

chrome/browser/autofill/form_structure_browsertest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/file_path.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 29 matching lines @@
   int write_size = file_util::WriteFile(file, content.c_str(),
                                         content.length());
   return write_size == static_cast<int>(content.length());
 }
 
 // Convert |html| to URL format, and return the converted string.
 const std::string ConvertToURLFormat(const std::string& html) {
   return std::string("data:text/html;charset=utf-8,") + html;
 }
 
-// Compare |output_file_source| with |form_string|. Returns true when they are
-// identical.
-bool CompareText(const std::string& output_file_source,
-                 const std::string& form_string) {
-  std::string output_file = output_file_source;
-  std::string form = form_string;
-
-  ReplaceSubstringsAfterOffset(&output_file, 0, "\r\n", " ");
-  ReplaceSubstringsAfterOffset(&output_file, 0, "\r", " ");
-  ReplaceSubstringsAfterOffset(&output_file, 0, "\n", " ");
-  ReplaceSubstringsAfterOffset(&form, 0, "\n", " ");
-
-  return (output_file == form);
+// Convert strings with platform end-of-line characters with spaces.
+const std::string NormalizeText(const std::string& text) {
+  std::string normalized = text;
+  ReplaceSubstringsAfterOffset(&normalized, 0, "\r\n", " ");
+  ReplaceSubstringsAfterOffset(&normalized, 0, "\r", " ");
+  ReplaceSubstringsAfterOffset(&normalized, 0, "\n", " ");
+  return normalized;
 }
 
 }  // namespace
 
 // Test class for verifying proper form structure as determined by AutoFill
 // heuristics. A test inputs each form file(e.g. form_[language_code].html),
 // loads its HTML content with a call to |NavigateToURL|, the |AutoFillManager|
 // associated with the tab contents is queried for the form structures that
 // were loaded and parsed. These form structures are serialized to string form.
 // If this is the first time test is run, a gold test result file is generated
@@ skipping 173 matching lines @@
     ASSERT_NE(static_cast<AutoFillManager*>(NULL), autofill_manager);
     std::vector<FormStructure*> forms = GetFormStructures(*autofill_manager);
 
     FilePath output_file_directory = GetOutputFileDirectory();
     FilePath output_file_path = output_file_directory.Append(
         input_file_path.BaseName().StripTrailingSeparators().ReplaceExtension(
             FILE_PATH_LITERAL(".out")));
 
     std::string output_file_source;
     if (file_util::ReadFileToString(output_file_path, &output_file_source)) {
-      ASSERT_TRUE(CompareText(
-          output_file_source,
-          FormStructureBrowserTest::FormStructuresToString(forms)));
+      ASSERT_EQ(NormalizeText(output_file_source),
+                NormalizeText(
+                    FormStructureBrowserTest::FormStructuresToString(forms)));
 
     } else {
       ASSERT_TRUE(WriteFile(
           output_file_path,
           FormStructureBrowserTest::FormStructuresToString(forms)));
     }
   }
 }