Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 600151: Circular relationships between .gyp files should be errors (Closed)

Created:
10 years, 10 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews
Visibility:
Public.

Description

Circular relationships between .gyp files should be errors. Make them errors, but currently only on the Mac. These relationships should be errors on all platforms, but some currently exist on non-Mac platforms. See http://crbug.com/35878. Because the Mac is the only platform where a circular dependency between .gyp files is known to cause tangible problems, the portions of Chromium's .gyp files that are used by Macs have been fixed to remove these relationships, and the check is left enabled on the Mac to ensure that no new ones are created. BUG=35308 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39128

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/gyp_chromium View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
Depends on http://codereview.chromium.org/600149. I'll roll the DEPS with this.
10 years, 10 months ago (2010-02-16 19:47:41 UTC) #1
TVL
10 years, 10 months ago (2010-02-16 19:55:30 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698