Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 600149: Check for circular dependencies between .gyp files.... (Closed)

Created:
10 years, 10 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Check for circular dependencies between .gyp files. Re-commit r782 backed out at r783. This check can be disabled with the transitional --no-circular-check command-line option. This command-line option should only be used if needed. When all of Chromium's .gyp files are fixed, the option will be removed, and there will be no way to bypass this check. BUG=110 TEST=None yet Committed: http://code.google.com/p/gyp/source/detail?r=785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -4 lines) Patch
M pylib/gyp/__init__.py View 4 chunks +14 lines, -3 lines 0 comments Download
M pylib/gyp/input.py View 3 chunks +58 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
10 years, 10 months ago (2010-02-16 19:44:50 UTC) #1
TVL
10 years, 10 months ago (2010-02-16 19:52:00 UTC) #2
cl description uses '_' in the options, but code seems to use '-'.

when rolling this in, I guess you'll make the chromium hook add the arg on non
windows platforms?

lgtm otherwise.

Powered by Google App Engine
This is Rietveld 408576698