Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: build/gyp_chromium

Issue 600151: Circular relationships between .gyp files should be errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 # This script is wrapper for Chromium that adds some support for how GYP 7 # This script is wrapper for Chromium that adds some support for how GYP
8 # is invoked by Chromium beyond what can be done in the gclient hooks. 8 # is invoked by Chromium beyond what can be done in the gclient hooks.
9 9
10 import glob 10 import glob
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 gyp_file = os.environ.get('CHROMIUM_GYP_FILE') 65 gyp_file = os.environ.get('CHROMIUM_GYP_FILE')
66 if gyp_file: 66 if gyp_file:
67 # Note that CHROMIUM_GYP_FILE values can't have backslashes as 67 # Note that CHROMIUM_GYP_FILE values can't have backslashes as
68 # path separators even on Windows due to the use of shlex.split(). 68 # path separators even on Windows due to the use of shlex.split().
69 args.extend(shlex.split(gyp_file)) 69 args.extend(shlex.split(gyp_file))
70 else: 70 else:
71 args.append(os.path.join(script_dir, 'all.gyp')) 71 args.append(os.path.join(script_dir, 'all.gyp'))
72 72
73 args.extend(['-I' + i for i in additional_include_files(args)]) 73 args.extend(['-I' + i for i in additional_include_files(args)])
74 74
75 # There shouldn't be a circular dependency relationship between .gyp files,
76 # but in Chromium's .gyp files, on non-Mac platforms, circular relationships
77 # currently exist. The check for circular dependencies is currently
78 # bypassed on other platforms, but is left enabled on the Mac, where a
79 # violation of the rule causes Xcode to misbehave badly.
80 # TODO(mark): Find and kill remaining circular dependencies, and remove this
81 # option. http://crbug.com/35878.
82 if sys.platform != 'darwin':
83 args.append('--no-circular-check')
84
75 print 'Updating projects from gyp files...' 85 print 'Updating projects from gyp files...'
76 sys.stdout.flush() 86 sys.stdout.flush()
77 87
78 # Off we go... 88 # Off we go...
79 sys.exit(gyp.main(args)) 89 sys.exit(gyp.main(args))
OLDNEW
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698