Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1894)

Issue 6001010: Move platform_thread to base/threading and put in the base namespace. I left ... (Closed)

Created:
9 years, 11 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews, tim (not reviewing), cbentzel+watch_chromium.org, Alpha Left Google, Sergey Ulanov, Raghu Simha, amit, Paweł Hajdan Jr., jam, ncarter (slow), apatrick_chromium, idana, dmac, darin-cc_chromium.org, awong, garykac, brettw-cc_chromium.org, pam+watch_chromium.org, native-client-reviews_googlegroups.com, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Move platform_thread to base/threading and put in the base namespace. I left a stub and "using" declarations in the old location to avoid having to change the entire project at once. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -1221 lines) Patch
M base/base.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M base/base.gypi View 3 chunks +6 lines, -6 lines 0 comments Download
M base/cancellation_flag.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/condition_variable_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/debug/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/file_util_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/lazy_instance.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/lazy_instance_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/lock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/lock.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/lock_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M base/message_loop_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/message_pump_glib.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/message_pump_glib_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/metrics/stats_table.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/non_thread_safe.h View 2 chunks +2 lines, -3 lines 0 comments Download
M base/observer_list_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M base/platform_thread.h View 1 chunk +12 lines, -75 lines 0 comments Download
D base/platform_thread_mac.mm View 1 chunk +0 lines, -54 lines 0 comments Download
D base/platform_thread_posix.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D base/platform_thread_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D base/platform_thread_win.cc View 1 chunk +0 lines, -143 lines 0 comments Download
M base/process_util_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/process_util_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/shared_memory_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/shared_memory_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/singleton.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/spin_wait.h View 3 chunks +6 lines, -6 lines 0 comments Download
M base/task.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
D base/thread_checker.h View 1 chunk +0 lines, -69 lines 0 comments Download
D base/thread_checker.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D base/thread_checker_unittest.cc View 1 chunk +0 lines, -142 lines 0 comments Download
M base/thread_collision_warner.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/thread_collision_warner_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M base/thread_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + base/threading/platform_thread.h View 3 chunks +20 lines, -8 lines 0 comments Download
A + base/threading/platform_thread_mac.mm View 3 chunks +4 lines, -4 lines 0 comments Download
A + base/threading/platform_thread_posix.cc View 6 chunks +71 lines, -73 lines 0 comments Download
A + base/threading/platform_thread_unittest.cc View 6 chunks +8 lines, -6 lines 0 comments Download
A + base/threading/platform_thread_win.cc View 2 chunks +5 lines, -1 line 0 comments Download
M base/threading/simple_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/simple_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/threading/thread_checker.h View 2 chunks +8 lines, -4 lines 0 comments Download
A + base/threading/thread_checker.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + base/threading/thread_checker_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M base/threading/watchdog.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/watchdog.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/watchdog_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/time_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/time_win_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/timer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/tools_sanity_unittest.cc View 3 chunks +5 lines, -1 line 0 comments Download
M base/waitable_event_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M base/waitable_event_watcher_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_main_posix.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/errorpage_uitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/geolocation/device_data_provider_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/printing/printing_layout_uitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/tests/browser_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_plugin_lib.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/gpu/gpu_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/nacl/nacl_main.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/plugin/plugin_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/ppapi_plugin/ppapi_plugin_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/profile_import/profile_import_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/service/service_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_test_interactive_test.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/test/automated_ui_tests/automated_ui_tests.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/automation/autocomplete_edit_proxy.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/automation/automation_proxy.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/browser_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/automation/proxy_launcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/automation/tab_proxy.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/memory_test/memory_test.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/mini_installer_test/chrome_mini_installer.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/mini_installer_test/mini_installer_test_util.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/tab_switching/tab_switching_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/ui/run_all_unittests.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/webdriver/commands/find_element_commands.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/webdriver/server.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/utility/utility_main.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/worker/worker_main.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/worker/worker_uitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome_frame/bind_status_callback_impl.cc View 12 chunks +13 lines, -11 lines 0 comments Download
M chrome_frame/cfproxy_private.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_automation.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_actions.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome_frame/test/run_all_unittests.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome_frame/urlmon_bind_status_callback.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 14 chunks +16 lines, -15 lines 0 comments Download
M chrome_frame/urlmon_url_request_private.h View 2 chunks +2 lines, -1 line 0 comments Download
M net/base/listen_socket.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/disk_cache/block_files.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/disk_cache/block_files.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/ocsp/nss_ocsp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/socket/tcp_client_socket_pool_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M remoting/base/tracer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/simple_database_system.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
TBR
9 years, 11 months ago (2010-12-31 20:00:03 UTC) #1
Timur Iskhodzhanov
Please watch the memory waterfall after commiting next time - it was red for 3 ...
9 years, 11 months ago (2011-01-03 20:22:59 UTC) #2
darin (slow to review)
LGTM On Fri, Dec 31, 2010 at 12:00 PM, <brettw@chromium.org> wrote: > Reviewers: darin, > ...
9 years, 11 months ago (2011-01-03 21:41:27 UTC) #3
brettw
9 years, 11 months ago (2011-01-03 21:46:41 UTC) #4
On Mon, Jan 3, 2011 at 12:22 PM,  <timurrrr@chromium.org> wrote:
> Please watch the memory waterfall after commiting next time - it was red for
> 3
> days!
> The tools_sanitiy_tests gone mad since the expected error stacktraces
> changed
> and stopped matching suppressions.

Sorry, will keep this in mind next time.

Brett

Powered by Google App Engine
This is Rietveld 408576698