When resolving URL, empty relative URL should remove ref component....

When resolving URL, empty relative URL should remove ref component.

R=brettw
BUG=16
TEST=none

[brettw, 2010-02-11 23:38:12]

What, no test?

[dglazkov, 2010-02-11 23:39:57]

What's this "test" you're speaking of...

Alright, I'll write a test. But wait. How? It's now upstream, so I have to write
the test, mark it as failing, then enable when this lands? :)

[brettw, 2010-02-11 23:42:50]

There is a special googleurl_unittests project. I bet you broke it if
you run them, so you should fix that. And if you didn't break it,
definitely add a new test. The tests go in the _unittest.cc file next
to the corresponding .cc

On Windows, this can be found under (build)/(temp_gyp)

Brett

On Thu, Feb 11, 2010 at 3:39 PM,  <dglazkov@chromium.org> wrote:
> What's this "test" you're speaking of...
>
> Alright, I'll write a test. But wait. How? It's now upstream, so I have to
> write
> the test, mark it as failing, then enable when this lands? :)
>
>
> http://codereview.chromium.org/600087
>

[dglazkov, 2010-02-11 23:47:27]

Yes, Captain!

[dglazkov, 2010-02-12 00:06:12]

I added unit test. Iz good now?

[brettw, 2010-02-12 01:39:17]

http://codereview.chromium.org/600087/diff/6/2004
File src/url_canon_relative.cc (right):

http://codereview.chromium.org/600087/diff/6/2004#newcode464
src/url_canon_relative.cc:464: for (int i = 0; i < base_len; i++)
I have a suggestion. More recently than this was written is Append being added
to the output object, which is slightly more efficient. Can you drop that in
here instead of this loop? It's declared in url_canon.h

[dglazkov, 2010-02-12 17:16:24]

Sure thing. Look again?

http://codereview.chromium.org/600087/diff/6/2004
File src/url_canon_relative.cc (right):

http://codereview.chromium.org/600087/diff/6/2004#newcode464
src/url_canon_relative.cc:464: for (int i = 0; i < base_len; i++)
On 2010/02/12 01:39:17, brettw wrote:
> I have a suggestion. More recently than this was written is Append being added
> to the output object, which is slightly more efficient. Can you drop that in
> here instead of this loop? It's declared in url_canon.h

Done.

[brettw, 2010-02-12 17:28:26]

LGTM

[brettw, 2010-02-12 19:03:21]

Landed as googleurl@122, I did not roll deps.