src/url_canon_unittest.cc - Issue 600087: When resolving URL, empty relative URL should remove ref component....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/url_canon_unittest.cc

Issue 600087: When resolving URL, empty relative URL should remove ref component.... (Closed) Base URL: http://google-url.googlecode.com/svn/trunk/

Patch Set: Changed to use Append. Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/url_canon_unittest.cc

===================================================================

--- src/url_canon_unittest.cc (revision 121)

+++ src/url_canon_unittest.cc (working copy)

@@ -1736,8 +1736,11 @@

// Basic absolute input.

{"http://host/a", true, false, "http://another/", true, false, false, NULL},

{"http://host/a", true, false, "http:////another/", true, false, false, NULL},

- // Empty relative URLs shouldn't change the input.

+ // Empty relative URLs should only remove the ref part of the URL,

+ // leaving the rest unchanged.

{"http://foo/bar", true, false, "", true, true, true, "http://foo/bar"},

+ {"http://foo/bar#ref", true, false, "", true, true, true, "http://foo/bar"},

+ {"http://foo/bar#", true, false, "", true, true, true, "http://foo/bar"},

// Spaces at the ends of the relative path should be ignored.

{"http://foo/bar", true, false, " another ", true, true, true, "http://foo/another"},

{"http://foo/bar", true, false, " . ", true, true, true, "http://foo/"},

« no previous file with comments | « src/url_canon_relative.cc ('k') | no next file » | no next file with comments »