Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: views/controls/textfield/native_textfield_gtk.h

Issue 5988010: focus reverse traversal was not working for TextfieldViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: explicitly forward key/focus event to TextfieldViews Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/native_textfield_gtk.h
diff --git a/views/controls/textfield/native_textfield_gtk.h b/views/controls/textfield/native_textfield_gtk.h
index 7e1f7e86578996aa8a0378c1cab9c33cd0c2f232..dd251a4093f7975f55c435e7f8e6e37818f6b3c7 100644
--- a/views/controls/textfield/native_textfield_gtk.h
+++ b/views/controls/textfield/native_textfield_gtk.h
@@ -41,19 +41,26 @@ class NativeTextfieldGtk : public NativeControlGtk,
virtual void UpdateFont();
virtual void UpdateIsPassword();
virtual void UpdateEnabled();
- virtual bool IsPassword();
virtual gfx::Insets CalculateInsets();
virtual void UpdateHorizontalMargins();
virtual void UpdateVerticalMargins();
- virtual void SetFocus();
+ virtual bool SetFocus();
virtual View* GetView();
virtual gfx::NativeView GetTestingHandle() const;
virtual bool IsIMEComposing() const;
+ virtual bool OnKeyPressed(const views::KeyEvent& e) { return false; }
sky 2011/01/05 22:57:35 Don't inline virtual methods.
+ virtual bool OnKeyReleased(const views::KeyEvent& e) { return false; }
+ virtual void WillGainFocus() {}
+ virtual void DidGainFocus() {}
+ virtual void WillLoseFocus() {}
// Overridden from NativeControlGtk:
virtual void CreateNativeControl();
virtual void NativeControlCreated(GtkWidget* widget);
+ // Returns true if the textfield is for password.
+ bool IsPassword();
+
private:
Textfield* textfield_;
« no previous file with comments | « no previous file | views/controls/textfield/native_textfield_gtk.cc » ('j') | views/controls/textfield/native_textfield_win.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698