Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: views/controls/textfield/native_textfield_gtk.cc

Issue 5988010: focus reverse traversal was not working for TextfieldViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: explicitly forward key/focus event to TextfieldViews Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/native_textfield_gtk.cc
diff --git a/views/controls/textfield/native_textfield_gtk.cc b/views/controls/textfield/native_textfield_gtk.cc
index 2878b3c166eed944c89158e7ec0bbf4abeda216c..e3ffc2d5db7c241c9dfe56d36a0cbf125174ac77 100644
--- a/views/controls/textfield/native_textfield_gtk.cc
+++ b/views/controls/textfield/native_textfield_gtk.cc
@@ -257,10 +257,6 @@ void NativeTextfieldGtk::UpdateEnabled() {
SetEnabled(textfield_->IsEnabled());
}
-bool NativeTextfieldGtk::IsPassword() {
- return textfield_->IsPassword();
-}
-
gfx::Insets NativeTextfieldGtk::CalculateInsets() {
if (!native_view())
return gfx::Insets();
@@ -329,8 +325,9 @@ void NativeTextfieldGtk::UpdateVerticalMargins() {
}
}
-void NativeTextfieldGtk::SetFocus() {
+bool NativeTextfieldGtk::SetFocus() {
Focus();
+ return true;
}
View* NativeTextfieldGtk::GetView() {
@@ -446,4 +443,8 @@ void NativeTextfieldGtk::NativeControlCreated(GtkWidget* widget) {
g_signal_connect(widget, "activate", G_CALLBACK(OnActivateHandler), this);
}
+bool NativeTextfieldGtk::IsPassword() {
+ return textfield_->IsPassword();
+}
+
} // namespace views

Powered by Google App Engine
This is Rietveld 408576698