focus reverse traversal was not working for TextfieldViews.

views/controls/textfield/native_textfield_gtk.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_GTK_H_
 #define VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_GTK_H_
 #pragma once
 
 #include <gtk/gtk.h>
 
@@ skipping 23 matching lines @@
   virtual string16 GetSelectedText() const;
   virtual void SelectAll();
   virtual void ClearSelection();
   virtual void UpdateBorder();
   virtual void UpdateTextColor();
   virtual void UpdateBackgroundColor();
   virtual void UpdateReadOnly();
   virtual void UpdateFont();
   virtual void UpdateIsPassword();
   virtual void UpdateEnabled();
-  virtual bool IsPassword();
   virtual gfx::Insets CalculateInsets();
   virtual void UpdateHorizontalMargins();
   virtual void UpdateVerticalMargins();
-  virtual void SetFocus();
+  virtual bool SetFocus();
   virtual View* GetView();
   virtual gfx::NativeView GetTestingHandle() const;
   virtual bool IsIMEComposing() const;
+  virtual bool OnKeyPressed(const views::KeyEvent& e) { return false; }

[sky, 2011/01/05 22:57:35]

Don't inline virtual methods.

+  virtual bool OnKeyReleased(const views::KeyEvent& e) { return false; }
+  virtual void WillGainFocus() {}
+  virtual void DidGainFocus() {}
+  virtual void WillLoseFocus() {}
 
   // Overridden from NativeControlGtk:
   virtual void CreateNativeControl();
   virtual void NativeControlCreated(GtkWidget* widget);
 
+  // Returns true if the textfield is for password.
+  bool IsPassword();
+
  private:
   Textfield* textfield_;
 
   // Callback when the entry text changes.
   static gboolean OnKeyPressEventHandler(
       GtkWidget* entry,
       GdkEventKey* event,
       NativeTextfieldGtk* textfield);
   gboolean OnKeyPressEvent(GdkEventKey* event);
   static gboolean OnActivateHandler(
       GtkWidget* entry,
       NativeTextfieldGtk* textfield);
   gboolean OnActivate();
   static gboolean OnChangedHandler(
       GtkWidget* entry,
       NativeTextfieldGtk* textfield);
   gboolean OnChanged();
 
   DISALLOW_COPY_AND_ASSIGN(NativeTextfieldGtk);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_GTK_H_