Issue 5986014: Remove RecordWriteStub from X64 and ARM platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5986014: Remove RecordWriteStub from X64 and ARM platforms. (Closed)

Created:
9 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove RecordWriteStub from X64 and ARM platforms. Committed: http://code.google.com/p/v8/source/detail?r=6136

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -101 lines)			Patch
M	src/arm/code-stubs-arm.h	View		1 chunk	+0 lines, -37 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View		3 chunks	+2 lines, -38 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	2 chunks	+2 lines, -11 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/5986014/diff/1/src/x64/codegen-x64.cc File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/5986014/diff/1/src/x64/codegen-x64.cc#newcode6817 src/x64/codegen-x64.cc:6817: __ RecordWriteHelper(tmp1.reg(), index2.reg(), object.reg()); Swap tmp1 and tmp2 ...

9 years, 11 months ago (2011-01-03 11:54:35 UTC) #2

William Hesse

9 years, 11 months ago (2011-01-04 08:54:37 UTC) #3

http://codereview.chromium.org/5986014/diff/1/src/x64/codegen-x64.cc
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/5986014/diff/1/src/x64/codegen-x64.cc#newcode6817
src/x64/codegen-x64.cc:6817: __ RecordWriteHelper(tmp1.reg(), index2.reg(),
object.reg());
On 2011/01/03 11:54:35, Lasse Reichstein wrote:
> Swap tmp1 and tmp2 here, just for consistency.

Done.

Expand Messages | Collapse Messages

Issue 5986014: Remove RecordWriteStub from X64 and ARM platforms. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages