Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 5986014: Remove RecordWriteStub from X64 and ARM platforms. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/x64/code-stubs-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5600 matching lines...) Expand 10 before | Expand all | Expand 10 after
5611 __ ldr(tmp2, MemOperand(tmp1, index2)); 5611 __ ldr(tmp2, MemOperand(tmp1, index2));
5612 __ str(tmp3, MemOperand(tmp1, index2)); 5612 __ str(tmp3, MemOperand(tmp1, index2));
5613 __ str(tmp2, MemOperand(tmp1, index1)); 5613 __ str(tmp2, MemOperand(tmp1, index1));
5614 5614
5615 Label done; 5615 Label done;
5616 __ InNewSpace(tmp1, tmp2, eq, &done); 5616 __ InNewSpace(tmp1, tmp2, eq, &done);
5617 // Possible optimization: do a check that both values are Smis 5617 // Possible optimization: do a check that both values are Smis
5618 // (or them and test against Smi mask.) 5618 // (or them and test against Smi mask.)
5619 5619
5620 __ mov(tmp2, tmp1); 5620 __ mov(tmp2, tmp1);
5621 RecordWriteStub recordWrite1(tmp1, index1, tmp3); 5621 __ add(index1, index1, tmp1);
5622 __ CallStub(&recordWrite1); 5622 __ add(index2, index2, tmp1);
5623 5623 __ RecordWriteHelper(tmp1, index1, tmp3);
5624 RecordWriteStub recordWrite2(tmp2, index2, tmp3); 5624 __ RecordWriteHelper(tmp2, index2, tmp3);
5625 __ CallStub(&recordWrite2);
5626
5627 __ bind(&done); 5625 __ bind(&done);
5628 5626
5629 deferred->BindExit(); 5627 deferred->BindExit();
5630 __ LoadRoot(tmp1, Heap::kUndefinedValueRootIndex); 5628 __ LoadRoot(tmp1, Heap::kUndefinedValueRootIndex);
5631 frame_->EmitPush(tmp1); 5629 frame_->EmitPush(tmp1);
5632 } 5630 }
5633 5631
5634 5632
5635 void CodeGenerator::GenerateCallFunction(ZoneList<Expression*>* args) { 5633 void CodeGenerator::GenerateCallFunction(ZoneList<Expression*>* args) {
5636 Comment cmnt(masm_, "[ GenerateCallFunction"); 5634 Comment cmnt(masm_, "[ GenerateCallFunction");
(...skipping 1733 matching lines...) Expand 10 before | Expand all | Expand 10 after
7370 BinaryOpIC::GetName(runtime_operands_type_)); 7368 BinaryOpIC::GetName(runtime_operands_type_));
7371 return name_; 7369 return name_;
7372 } 7370 }
7373 7371
7374 7372
7375 #undef __ 7373 #undef __
7376 7374
7377 } } // namespace v8::internal 7375 } } // namespace v8::internal
7378 7376
7379 #endif // V8_TARGET_ARCH_ARM 7377 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/x64/code-stubs-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698