Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 5986014: Remove RecordWriteStub from X64 and ARM platforms. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.h ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6795 matching lines...) Expand 10 before | Expand all | Expand 10 after
6806 __ movq(tmp2.reg(), Operand(index2.reg(), 0)); 6806 __ movq(tmp2.reg(), Operand(index2.reg(), 0));
6807 __ movq(Operand(index2.reg(), 0), object.reg()); 6807 __ movq(Operand(index2.reg(), 0), object.reg());
6808 __ movq(Operand(index1.reg(), 0), tmp2.reg()); 6808 __ movq(Operand(index1.reg(), 0), tmp2.reg());
6809 6809
6810 Label done; 6810 Label done;
6811 __ InNewSpace(tmp1.reg(), tmp2.reg(), equal, &done); 6811 __ InNewSpace(tmp1.reg(), tmp2.reg(), equal, &done);
6812 // Possible optimization: do a check that both values are Smis 6812 // Possible optimization: do a check that both values are Smis
6813 // (or them and test against Smi mask.) 6813 // (or them and test against Smi mask.)
6814 6814
6815 __ movq(tmp2.reg(), tmp1.reg()); 6815 __ movq(tmp2.reg(), tmp1.reg());
6816 RecordWriteStub recordWrite1(tmp2.reg(), index1.reg(), object.reg()); 6816 __ RecordWriteHelper(tmp1.reg(), index1.reg(), object.reg());
6817 __ CallStub(&recordWrite1); 6817 __ RecordWriteHelper(tmp2.reg(), index2.reg(), object.reg());
6818
6819 RecordWriteStub recordWrite2(tmp1.reg(), index2.reg(), object.reg());
6820 __ CallStub(&recordWrite2);
6821
6822 __ bind(&done); 6818 __ bind(&done);
6823 6819
6824 deferred->BindExit(); 6820 deferred->BindExit();
6825 frame_->Push(Factory::undefined_value()); 6821 frame_->Push(Factory::undefined_value());
6826 } 6822 }
6827 6823
6828 6824
6829 void CodeGenerator::GenerateCallFunction(ZoneList<Expression*>* args) { 6825 void CodeGenerator::GenerateCallFunction(ZoneList<Expression*>* args) {
6830 Comment cmnt(masm_, "[ GenerateCallFunction"); 6826 Comment cmnt(masm_, "[ GenerateCallFunction");
6831 6827
(...skipping 1973 matching lines...) Expand 10 before | Expand all | Expand 10 after
8805 masm.GetCode(&desc); 8801 masm.GetCode(&desc);
8806 // Call the function from C++. 8802 // Call the function from C++.
8807 return FUNCTION_CAST<ModuloFunction>(buffer); 8803 return FUNCTION_CAST<ModuloFunction>(buffer);
8808 } 8804 }
8809 8805
8810 #endif 8806 #endif
8811 8807
8812 8808
8813 #undef __ 8809 #undef __
8814 8810
8815 void RecordWriteStub::Generate(MacroAssembler* masm) {
8816 masm->RecordWriteHelper(object_, addr_, scratch_);
8817 masm->ret(0);
8818 }
8819
8820 } } // namespace v8::internal 8811 } } // namespace v8::internal
8821 8812
8822 #endif // V8_TARGET_ARCH_X64 8813 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.h ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698