Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 5986012: Move thread local stuff from base to base/threading and consistently use the... (Closed)

Created:
9 years, 11 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, amit, brettw-cc_chromium.org, jam, pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Move thread local stuff from base to base/threading and consistently use the base namespace. This also fixes references to TLSSlot to base::ThreadLocalStorage::Slot. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -856 lines) Patch
M base/base.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M base/base.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M base/message_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/stats_table.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/metrics/stats_table.cc View 1 chunk +1 line, -1 line 0 comments Download
D base/thread_local.h View 1 chunk +0 lines, -127 lines 0 comments Download
D base/thread_local_posix.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D base/thread_local_storage.h View 1 chunk +0 lines, -95 lines 0 comments Download
D base/thread_local_storage_posix.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D base/thread_local_storage_unittest.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D base/thread_local_storage_win.cc View 1 chunk +0 lines, -194 lines 0 comments Download
D base/thread_local_unittest.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D base/thread_local_win.cc View 1 chunk +0 lines, -42 lines 0 comments Download
MM base/thread_restrictions.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/threading/thread_local.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/threading/thread_local_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + base/threading/thread_local_storage.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + base/threading/thread_local_storage_posix.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + base/threading/thread_local_storage_unittest.cc View 7 chunks +14 lines, -8 lines 0 comments Download
A + base/threading/thread_local_storage_win.cc View 2 chunks +6 lines, -2 lines 0 comments Download
A + base/threading/thread_local_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + base/threading/thread_local_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/tracked_objects.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/tracked_objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/notification_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/worker/worker_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/buggy_bho_handling.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/crash_reporting/crash_metrics.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/metrics_service.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome_frame/urlmon_moniker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/utils.cc View 1 chunk +1 line, -1 line 0 comments Download
MM net/base/dns_reload_timer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_transport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR
9 years, 11 months ago (2010-12-30 18:54:46 UTC) #1
darin (slow to review)
9 years, 11 months ago (2011-01-03 21:36:01 UTC) #2
LGTM

On Thu, Dec 30, 2010 at 10:54 AM, <brettw@chromium.org> wrote:

> Reviewers: darin,
>
> Message:
> TBR
>
> Description:
> Move thread local stuff from base to base/threading and consistently use
> the
> base namespace. This also fixes references to TLSSlot to
> base::ThreadLocalStorage::Slot.
>
> TEST=it compiles
> BUG=none
>
> Please review this at http://codereview.chromium.org/5986012/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     base/base.gyp
>  M     base/base.gypi
>  M     base/message_loop.cc
>  M     base/metrics/stats_table.h
>  M     base/metrics/stats_table.cc
>  D     base/thread_local.h
>  D     base/thread_local_posix.cc
>  D     base/thread_local_storage.h
>  D     base/thread_local_storage_posix.cc
>  D     base/thread_local_storage_unittest.cc
>  D     base/thread_local_storage_win.cc
>  D     base/thread_local_unittest.cc
>  D     base/thread_local_win.cc
>  MM    base/thread_restrictions.cc
>  A  +  base/threading/thread_local.h
>  A  +  base/threading/thread_local_posix.cc
>  A  +  base/threading/thread_local_storage.h
>  A  +  base/threading/thread_local_storage_posix.cc
>  A  +  base/threading/thread_local_storage_unittest.cc
>  A  +  base/threading/thread_local_storage_win.cc
>  A  +  base/threading/thread_local_unittest.cc
>  A  +  base/threading/thread_local_win.cc
>  M     base/tracked_objects.h
>  M     base/tracked_objects.cc
>  M     chrome/common/notification_service.cc
>  M     chrome/plugin/plugin_thread.cc
>  M     chrome/renderer/render_thread.cc
>  M     chrome/worker/worker_thread.cc
>  M     chrome_frame/buggy_bho_handling.h
>  M     chrome_frame/chrome_active_document.cc
>  M     chrome_frame/crash_reporting/crash_metrics.h
>  M     chrome_frame/metrics_service.h
>  M     chrome_frame/urlmon_moniker.h
>  M     chrome_frame/utils.cc
>  MM    net/base/dns_reload_timer.cc
>  M     webkit/plugins/ppapi/ppb_transport_impl.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698