Make IPC::Channel::Listener:OnMessageReceived have a return value indicating ...

Make IPC::Channel::Listener:OnMessageReceived have a return value indicating whether a message was processed or not.

TBR=brettw

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70139

[jam, 2010-12-24 06:18:53]

This is the change we discussed.  I'm going to check it in as TBR while the tree
is unused, given how many files this touches.

[brettw, 2010-12-24 21:18:59]

LGTM

[darin (slow to review), 2010-12-25 22:32:06]

Can you say more about how this will be used?  I'm interested, because I
originally resisted adding a boolean return value here.  If it is used to
implement message filters, then what about the case where a particular
listener wants to handle IPCs on a separate thread?

-Darin



On Thu, Dec 23, 2010 at 10:18 PM, <jam@chromium.org> wrote:

> Reviewers: brettw,
>
> Message:
> This is the change we discussed.  I'm going to check it in as TBR while the
> tree
> is unused, given how many files this touches.
>
> Description:
> Make IPC::Channel::Listener:OnMessageReceived have a return value
> indicating
> whether a message was processed or not.
>
> TBR=brettw
>
> Please review this at http://codereview.chromium.org/5978003/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/appcache/appcache_dispatcher_host.cc
>  M     chrome/browser/automation/automation_provider.h
>  M     chrome/browser/automation/automation_provider.cc
>  M     chrome/browser/automation/chrome_frame_automation_provider.h
>  M     chrome/browser/automation/chrome_frame_automation_provider.cc
>  M     chrome/browser/automation/testing_automation_provider.h
>  M     chrome/browser/automation/testing_automation_provider.cc
>  M     chrome/browser/gpu_process_host.h
>  M     chrome/browser/gpu_process_host.cc
>  M     chrome/browser/gpu_process_host_ui_shim.h
>  M     chrome/browser/gpu_process_host_ui_shim.cc
>  M     chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
>  M     chrome/browser/nacl_host/nacl_broker_host_win.h
>  M     chrome/browser/nacl_host/nacl_broker_host_win.cc
>  M     chrome/browser/nacl_host/nacl_process_host.h
>  M     chrome/browser/nacl_host/nacl_process_host.cc
>  M     chrome/browser/plugin_data_remover.h
>  M     chrome/browser/plugin_data_remover.cc
>  M     chrome/browser/plugin_process_host.h
>  M     chrome/browser/plugin_process_host.cc
>  M     chrome/browser/ppapi_plugin_process_host.h
>  M     chrome/browser/ppapi_plugin_process_host.cc
>  M     chrome/browser/profile_import_process_host.h
>  M     chrome/browser/profile_import_process_host.cc
>  M     chrome/browser/renderer_host/browser_render_process_host.h
>  M     chrome/browser/renderer_host/browser_render_process_host.cc
>  M     chrome/browser/renderer_host/mock_render_process_host.h
>  M     chrome/browser/renderer_host/mock_render_process_host.cc
>  M     chrome/browser/renderer_host/render_view_host.h
>  M     chrome/browser/renderer_host/render_view_host.cc
>  M     chrome/browser/renderer_host/render_widget_host.h
>  M     chrome/browser/renderer_host/render_widget_host.cc
>  M     chrome/browser/renderer_host/test/test_render_view_host.h
>  M     chrome/browser/renderer_host/test/test_render_view_host.cc
>  M     chrome/browser/service/service_process_control.h
>  M     chrome/browser/service/service_process_control.cc
>  M     chrome/browser/utility_process_host.h
>  M     chrome/browser/utility_process_host.cc
>  M     chrome/browser/worker_host/worker_process_host.h
>  M     chrome/browser/worker_host/worker_process_host.cc
>  M     chrome/common/appcache/appcache_dispatcher.h
>  M     chrome/common/child_process_host.h
>  M     chrome/common/child_process_host.cc
>  M     chrome/common/child_thread.h
>  M     chrome/common/child_thread.cc
>  M     chrome/common/file_system/file_system_dispatcher.h
>  M     chrome/common/message_router.h
>  M     chrome/common/message_router.cc
>  M     chrome/common/resource_dispatcher.h
>  M     chrome/common/socket_stream_dispatcher.h
>  M     chrome/common/webmessageportchannel_impl.h
>  M     chrome/common/webmessageportchannel_impl.cc
>  M     chrome/gpu/gpu_channel.h
>  M     chrome/gpu/gpu_channel.cc
>  M     chrome/gpu/gpu_command_buffer_stub.h
>  M     chrome/gpu/gpu_command_buffer_stub.cc
>  M     chrome/gpu/gpu_thread.h
>  M     chrome/gpu/gpu_thread.cc
>  M     chrome/gpu/gpu_video_decoder.h
>  M     chrome/gpu/gpu_video_decoder.cc
>  M     chrome/gpu/gpu_video_service.h
>  M     chrome/gpu/gpu_video_service.cc
>  M     chrome/nacl/broker_thread.h
>  M     chrome/nacl/broker_thread.cc
>  M     chrome/nacl/nacl_thread.h
>  M     chrome/nacl/nacl_thread.cc
>  M     chrome/plugin/command_buffer_stub.h
>  M     chrome/plugin/command_buffer_stub.cc
>  M     chrome/plugin/npobject_proxy.h
>  M     chrome/plugin/npobject_proxy.cc
>  M     chrome/plugin/npobject_stub.h
>  M     chrome/plugin/npobject_stub.cc
>  M     chrome/plugin/plugin_channel.h
>  M     chrome/plugin/plugin_channel.cc
>  M     chrome/plugin/plugin_channel_base.h
>  M     chrome/plugin/plugin_channel_base.cc
>  M     chrome/plugin/plugin_thread.h
>  M     chrome/plugin/plugin_thread.cc
>  M     chrome/plugin/webplugin_delegate_stub.h
>  M     chrome/plugin/webplugin_delegate_stub.cc
>  M     chrome/ppapi_plugin/ppapi_thread.h
>  M     chrome/ppapi_plugin/ppapi_thread.cc
>  M     chrome/profile_import/profile_import_thread.h
>  M     chrome/profile_import/profile_import_thread.cc
>  M     chrome/renderer/command_buffer_proxy.h
>  M     chrome/renderer/command_buffer_proxy.cc
>  M     chrome/renderer/device_orientation_dispatcher.h
>  M     chrome/renderer/devtools_agent.h
>  M     chrome/renderer/devtools_client.h
>  M     chrome/renderer/geolocation_dispatcher_old.h
>  M     chrome/renderer/gpu_channel_host.h
>  M     chrome/renderer/gpu_channel_host.cc
>  M     chrome/renderer/gpu_video_decoder_host.h
>  M     chrome/renderer/gpu_video_decoder_host.cc
>  M     chrome/renderer/indexed_db_dispatcher.h
>  M     chrome/renderer/mock_render_thread.h
>  M     chrome/renderer/mock_render_thread.cc
>  M     chrome/renderer/notification_provider.h
>  M     chrome/renderer/plugin_channel_host.h
>  M     chrome/renderer/plugin_channel_host.cc
>  M     chrome/renderer/render_thread.h
>  M     chrome/renderer/render_thread.cc
>  M     chrome/renderer/render_view.h
>  M     chrome/renderer/render_view.cc
>  M     chrome/renderer/render_widget.h
>  M     chrome/renderer/render_widget.cc
>  M     chrome/renderer/renderer_main_unittest.cc
>  M
> chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
>  M     chrome/renderer/safe_browsing/render_view_fake_resources_test.h
>  M     chrome/renderer/safe_browsing/render_view_fake_resources_test.cc
>  M     chrome/renderer/speech_input_dispatcher.h
>  M     chrome/renderer/webplugin_delegate_proxy.h
>  M     chrome/renderer/webplugin_delegate_proxy.cc
>  M     chrome/renderer/websharedworker_proxy.h
>  M     chrome/renderer/websharedworker_proxy.cc
>  M     chrome/renderer/webworker_proxy.h
>  M     chrome/renderer/webworker_proxy.cc
>  M     chrome/service/service_ipc_server.h
>  M     chrome/service/service_ipc_server.cc
>  M     chrome/service/service_utility_process_host.h
>  M     chrome/service/service_utility_process_host.cc
>  M     chrome/test/automation/automation_proxy.h
>  M     chrome/test/automation/automation_proxy.cc
>  M     chrome/test/automation/automation_proxy_uitest.h
>  M     chrome/test/automation/automation_proxy_uitest.cc
>  M     chrome/test/automation/tab_proxy.h
>  M     chrome/test/automation/tab_proxy.cc
>  M     chrome/utility/utility_thread.h
>  M     chrome/utility/utility_thread.cc
>  M     chrome/worker/websharedworker_stub.h
>  M     chrome/worker/websharedworker_stub.cc
>  M     chrome/worker/webworker_stub.h
>  M     chrome/worker/webworker_stub.cc
>  M     chrome/worker/worker_thread.h
>  M     chrome/worker/worker_thread.cc
>  M     chrome_frame/cfproxy.h
>  M     chrome_frame/cfproxy_private.h
>  M     chrome_frame/cfproxy_proxy.cc
>  M     chrome_frame/cfproxy_test.cc
>  M     chrome_frame/chrome_frame_delegate.h
>  M     chrome_frame/chrome_frame_delegate.cc
>  M     chrome_frame/external_tab.h
>  M     chrome_frame/external_tab.cc
>  M     chrome_frame/test/net/test_automation_provider.h
>  M     chrome_frame/test/net/test_automation_provider.cc
>  M     ipc/ipc_channel.h
>  M     ipc/ipc_channel_posix_unittest.cc
>  M     ipc/ipc_channel_proxy.h
>  M     ipc/ipc_channel_proxy.cc
>  M     ipc/ipc_fuzzing_tests.cc
>  M     ipc/ipc_message_macros.h
>  M     ipc/ipc_send_fds_test.cc
>  M     ipc/ipc_sync_channel.h
>  M     ipc/ipc_sync_channel.cc
>  M     ipc/ipc_sync_channel_unittest.cc
>  M     ipc/ipc_sync_message_unittest.cc
>  M     ipc/ipc_tests.cc
>  M     ipc/sync_socket_unittest.cc
>  M     ppapi/proxy/dispatcher.h
>  M     ppapi/proxy/dispatcher.cc
>  M     ppapi/proxy/interface_proxy.h
>  M     ppapi/proxy/plugin_dispatcher.h
>  M     ppapi/proxy/plugin_dispatcher.cc
>  M     ppapi/proxy/ppb_audio_config_proxy.h
>  M     ppapi/proxy/ppb_audio_config_proxy.cc
>  M     ppapi/proxy/ppb_audio_proxy.h
>  M     ppapi/proxy/ppb_audio_proxy.cc
>  M     ppapi/proxy/ppb_buffer_proxy.h
>  M     ppapi/proxy/ppb_buffer_proxy.cc
>  M     ppapi/proxy/ppb_char_set_proxy.h
>  M     ppapi/proxy/ppb_char_set_proxy.cc
>  M     ppapi/proxy/ppb_core_proxy.h
>  M     ppapi/proxy/ppb_core_proxy.cc
>  M     ppapi/proxy/ppb_cursor_control_proxy.h
>  M     ppapi/proxy/ppb_cursor_control_proxy.cc
>  M     ppapi/proxy/ppb_flash_proxy.h
>  M     ppapi/proxy/ppb_flash_proxy.cc
>  M     ppapi/proxy/ppb_font_proxy.h
>  M     ppapi/proxy/ppb_font_proxy.cc
>  M     ppapi/proxy/ppb_fullscreen_proxy.h
>  M     ppapi/proxy/ppb_fullscreen_proxy.cc
>  M     ppapi/proxy/ppb_graphics_2d_proxy.h
>  M     ppapi/proxy/ppb_graphics_2d_proxy.cc
>  M     ppapi/proxy/ppb_image_data_proxy.h
>  M     ppapi/proxy/ppb_image_data_proxy.cc
>  M     ppapi/proxy/ppb_instance_proxy.h
>  M     ppapi/proxy/ppb_instance_proxy.cc
>  M     ppapi/proxy/ppb_pdf_proxy.h
>  M     ppapi/proxy/ppb_pdf_proxy.cc
>  M     ppapi/proxy/ppb_testing_proxy.h
>  M     ppapi/proxy/ppb_testing_proxy.cc
>  M     ppapi/proxy/ppb_url_loader_proxy.h
>  M     ppapi/proxy/ppb_url_loader_proxy.cc
>  M     ppapi/proxy/ppb_url_request_info_proxy.h
>  M     ppapi/proxy/ppb_url_request_info_proxy.cc
>  M     ppapi/proxy/ppb_url_response_info_proxy.h
>  M     ppapi/proxy/ppb_url_response_info_proxy.cc
>  M     ppapi/proxy/ppb_var_deprecated_proxy.h
>  M     ppapi/proxy/ppb_var_deprecated_proxy.cc
>  M     ppapi/proxy/ppp_class_proxy.h
>  M     ppapi/proxy/ppp_class_proxy.cc
>  M     ppapi/proxy/ppp_instance_proxy.h
>  M     ppapi/proxy/ppp_instance_proxy.cc
>
>
>

[brettw, 2010-12-25 23:32:43]

On Sat, Dec 25, 2010 at 2:31 PM, Darin Fisher <darin@chromium.org> wrote:
> Can you say more about how this will be used?  I'm interested, because I
> originally resisted adding a boolean return value here.  If it is used to
> implement message filters, then what about the case where a particular
> listener wants to handle IPCs on a separate thread?

John already added a separate function to set the thread (I forget
exactly where this is, somewhere in the Chrome code). For this, he was
planning on having a sequence of listeners that could get attached to
a channel which would then get called in sequence until on processes
the message.

Brett

[jam, 2010-12-26 21:43:24]

This is orthogonal to the filter (which I only kept in chrome\browser, so
that it uses BrowserThread) case.  I found a lot of existing code, and
potential for a lot more, in places like RenderView and RenderViewHost that
want to filter messages on the main thread.  Rather than add a new interface
that is almost like IPC::Channel::Listener just to get a return value of
whether a message was processed or not, I figured we can have these two
classes keep a collection of Listener objects.

On Sat, Dec 25, 2010 at 2:31 PM, Darin Fisher <darin@chromium.org> wrote:

> Can you say more about how this will be used?  I'm interested, because I
> originally resisted adding a boolean return value here.  If it is used to
> implement message filters, then what about the case where a particular
> listener wants to handle IPCs on a separate thread?
>
> -Darin
>
>
>
> On Thu, Dec 23, 2010 at 10:18 PM, <jam@chromium.org> wrote:
>
>> Reviewers: brettw,
>>
>> Message:
>> This is the change we discussed.  I'm going to check it in as TBR while
>> the tree
>> is unused, given how many files this touches.
>>
>> Description:
>> Make IPC::Channel::Listener:OnMessageReceived have a return value
>> indicating
>> whether a message was processed or not.
>>
>> TBR=brettw
>>
>> Please review this at http://codereview.chromium.org/5978003/
>>
>> SVN Base: svn://chrome-svn/chrome/trunk/src/
>>
>> Affected files:
>>  M     chrome/browser/appcache/appcache_dispatcher_host.cc
>>  M     chrome/browser/automation/automation_provider.h
>>  M     chrome/browser/automation/automation_provider.cc
>>  M     chrome/browser/automation/chrome_frame_automation_provider.h
>>  M     chrome/browser/automation/chrome_frame_automation_provider.cc
>>  M     chrome/browser/automation/testing_automation_provider.h
>>  M     chrome/browser/automation/testing_automation_provider.cc
>>  M     chrome/browser/gpu_process_host.h
>>  M     chrome/browser/gpu_process_host.cc
>>  M     chrome/browser/gpu_process_host_ui_shim.h
>>  M     chrome/browser/gpu_process_host_ui_shim.cc
>>  M     chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
>>  M     chrome/browser/nacl_host/nacl_broker_host_win.h
>>  M     chrome/browser/nacl_host/nacl_broker_host_win.cc
>>  M     chrome/browser/nacl_host/nacl_process_host.h
>>  M     chrome/browser/nacl_host/nacl_process_host.cc
>>  M     chrome/browser/plugin_data_remover.h
>>  M     chrome/browser/plugin_data_remover.cc
>>  M     chrome/browser/plugin_process_host.h
>>  M     chrome/browser/plugin_process_host.cc
>>  M     chrome/browser/ppapi_plugin_process_host.h
>>  M     chrome/browser/ppapi_plugin_process_host.cc
>>  M     chrome/browser/profile_import_process_host.h
>>  M     chrome/browser/profile_import_process_host.cc
>>  M     chrome/browser/renderer_host/browser_render_process_host.h
>>  M     chrome/browser/renderer_host/browser_render_process_host.cc
>>  M     chrome/browser/renderer_host/mock_render_process_host.h
>>  M     chrome/browser/renderer_host/mock_render_process_host.cc
>>  M     chrome/browser/renderer_host/render_view_host.h
>>  M     chrome/browser/renderer_host/render_view_host.cc
>>  M     chrome/browser/renderer_host/render_widget_host.h
>>  M     chrome/browser/renderer_host/render_widget_host.cc
>>  M     chrome/browser/renderer_host/test/test_render_view_host.h
>>  M     chrome/browser/renderer_host/test/test_render_view_host.cc
>>  M     chrome/browser/service/service_process_control.h
>>  M     chrome/browser/service/service_process_control.cc
>>  M     chrome/browser/utility_process_host.h
>>  M     chrome/browser/utility_process_host.cc
>>  M     chrome/browser/worker_host/worker_process_host.h
>>  M     chrome/browser/worker_host/worker_process_host.cc
>>  M     chrome/common/appcache/appcache_dispatcher.h
>>  M     chrome/common/child_process_host.h
>>  M     chrome/common/child_process_host.cc
>>  M     chrome/common/child_thread.h
>>  M     chrome/common/child_thread.cc
>>  M     chrome/common/file_system/file_system_dispatcher.h
>>  M     chrome/common/message_router.h
>>  M     chrome/common/message_router.cc
>>  M     chrome/common/resource_dispatcher.h
>>  M     chrome/common/socket_stream_dispatcher.h
>>  M     chrome/common/webmessageportchannel_impl.h
>>  M     chrome/common/webmessageportchannel_impl.cc
>>  M     chrome/gpu/gpu_channel.h
>>  M     chrome/gpu/gpu_channel.cc
>>  M     chrome/gpu/gpu_command_buffer_stub.h
>>  M     chrome/gpu/gpu_command_buffer_stub.cc
>>  M     chrome/gpu/gpu_thread.h
>>  M     chrome/gpu/gpu_thread.cc
>>  M     chrome/gpu/gpu_video_decoder.h
>>  M     chrome/gpu/gpu_video_decoder.cc
>>  M     chrome/gpu/gpu_video_service.h
>>  M     chrome/gpu/gpu_video_service.cc
>>  M     chrome/nacl/broker_thread.h
>>  M     chrome/nacl/broker_thread.cc
>>  M     chrome/nacl/nacl_thread.h
>>  M     chrome/nacl/nacl_thread.cc
>>  M     chrome/plugin/command_buffer_stub.h
>>  M     chrome/plugin/command_buffer_stub.cc
>>  M     chrome/plugin/npobject_proxy.h
>>  M     chrome/plugin/npobject_proxy.cc
>>  M     chrome/plugin/npobject_stub.h
>>  M     chrome/plugin/npobject_stub.cc
>>  M     chrome/plugin/plugin_channel.h
>>  M     chrome/plugin/plugin_channel.cc
>>  M     chrome/plugin/plugin_channel_base.h
>>  M     chrome/plugin/plugin_channel_base.cc
>>  M     chrome/plugin/plugin_thread.h
>>  M     chrome/plugin/plugin_thread.cc
>>  M     chrome/plugin/webplugin_delegate_stub.h
>>  M     chrome/plugin/webplugin_delegate_stub.cc
>>  M     chrome/ppapi_plugin/ppapi_thread.h
>>  M     chrome/ppapi_plugin/ppapi_thread.cc
>>  M     chrome/profile_import/profile_import_thread.h
>>  M     chrome/profile_import/profile_import_thread.cc
>>  M     chrome/renderer/command_buffer_proxy.h
>>  M     chrome/renderer/command_buffer_proxy.cc
>>  M     chrome/renderer/device_orientation_dispatcher.h
>>  M     chrome/renderer/devtools_agent.h
>>  M     chrome/renderer/devtools_client.h
>>  M     chrome/renderer/geolocation_dispatcher_old.h
>>  M     chrome/renderer/gpu_channel_host.h
>>  M     chrome/renderer/gpu_channel_host.cc
>>  M     chrome/renderer/gpu_video_decoder_host.h
>>  M     chrome/renderer/gpu_video_decoder_host.cc
>>  M     chrome/renderer/indexed_db_dispatcher.h
>>  M     chrome/renderer/mock_render_thread.h
>>  M     chrome/renderer/mock_render_thread.cc
>>  M     chrome/renderer/notification_provider.h
>>  M     chrome/renderer/plugin_channel_host.h
>>  M     chrome/renderer/plugin_channel_host.cc
>>  M     chrome/renderer/render_thread.h
>>  M     chrome/renderer/render_thread.cc
>>  M     chrome/renderer/render_view.h
>>  M     chrome/renderer/render_view.cc
>>  M     chrome/renderer/render_widget.h
>>  M     chrome/renderer/render_widget.cc
>>  M     chrome/renderer/renderer_main_unittest.cc
>>  M
>> chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
>>  M     chrome/renderer/safe_browsing/render_view_fake_resources_test.h
>>  M     chrome/renderer/safe_browsing/render_view_fake_resources_test.cc
>>  M     chrome/renderer/speech_input_dispatcher.h
>>  M     chrome/renderer/webplugin_delegate_proxy.h
>>  M     chrome/renderer/webplugin_delegate_proxy.cc
>>  M     chrome/renderer/websharedworker_proxy.h
>>  M     chrome/renderer/websharedworker_proxy.cc
>>  M     chrome/renderer/webworker_proxy.h
>>  M     chrome/renderer/webworker_proxy.cc
>>  M     chrome/service/service_ipc_server.h
>>  M     chrome/service/service_ipc_server.cc
>>  M     chrome/service/service_utility_process_host.h
>>  M     chrome/service/service_utility_process_host.cc
>>  M     chrome/test/automation/automation_proxy.h
>>  M     chrome/test/automation/automation_proxy.cc
>>  M     chrome/test/automation/automation_proxy_uitest.h
>>  M     chrome/test/automation/automation_proxy_uitest.cc
>>  M     chrome/test/automation/tab_proxy.h
>>  M     chrome/test/automation/tab_proxy.cc
>>  M     chrome/utility/utility_thread.h
>>  M     chrome/utility/utility_thread.cc
>>  M     chrome/worker/websharedworker_stub.h
>>  M     chrome/worker/websharedworker_stub.cc
>>  M     chrome/worker/webworker_stub.h
>>  M     chrome/worker/webworker_stub.cc
>>  M     chrome/worker/worker_thread.h
>>  M     chrome/worker/worker_thread.cc
>>  M     chrome_frame/cfproxy.h
>>  M     chrome_frame/cfproxy_private.h
>>  M     chrome_frame/cfproxy_proxy.cc
>>  M     chrome_frame/cfproxy_test.cc
>>  M     chrome_frame/chrome_frame_delegate.h
>>  M     chrome_frame/chrome_frame_delegate.cc
>>  M     chrome_frame/external_tab.h
>>  M     chrome_frame/external_tab.cc
>>  M     chrome_frame/test/net/test_automation_provider.h
>>  M     chrome_frame/test/net/test_automation_provider.cc
>>  M     ipc/ipc_channel.h
>>  M     ipc/ipc_channel_posix_unittest.cc
>>  M     ipc/ipc_channel_proxy.h
>>  M     ipc/ipc_channel_proxy.cc
>>  M     ipc/ipc_fuzzing_tests.cc
>>  M     ipc/ipc_message_macros.h
>>  M     ipc/ipc_send_fds_test.cc
>>  M     ipc/ipc_sync_channel.h
>>  M     ipc/ipc_sync_channel.cc
>>  M     ipc/ipc_sync_channel_unittest.cc
>>  M     ipc/ipc_sync_message_unittest.cc
>>  M     ipc/ipc_tests.cc
>>  M     ipc/sync_socket_unittest.cc
>>  M     ppapi/proxy/dispatcher.h
>>  M     ppapi/proxy/dispatcher.cc
>>  M     ppapi/proxy/interface_proxy.h
>>  M     ppapi/proxy/plugin_dispatcher.h
>>  M     ppapi/proxy/plugin_dispatcher.cc
>>  M     ppapi/proxy/ppb_audio_config_proxy.h
>>  M     ppapi/proxy/ppb_audio_config_proxy.cc
>>  M     ppapi/proxy/ppb_audio_proxy.h
>>  M     ppapi/proxy/ppb_audio_proxy.cc
>>  M     ppapi/proxy/ppb_buffer_proxy.h
>>  M     ppapi/proxy/ppb_buffer_proxy.cc
>>  M     ppapi/proxy/ppb_char_set_proxy.h
>>  M     ppapi/proxy/ppb_char_set_proxy.cc
>>  M     ppapi/proxy/ppb_core_proxy.h
>>  M     ppapi/proxy/ppb_core_proxy.cc
>>  M     ppapi/proxy/ppb_cursor_control_proxy.h
>>  M     ppapi/proxy/ppb_cursor_control_proxy.cc
>>  M     ppapi/proxy/ppb_flash_proxy.h
>>  M     ppapi/proxy/ppb_flash_proxy.cc
>>  M     ppapi/proxy/ppb_font_proxy.h
>>  M     ppapi/proxy/ppb_font_proxy.cc
>>  M     ppapi/proxy/ppb_fullscreen_proxy.h
>>  M     ppapi/proxy/ppb_fullscreen_proxy.cc
>>  M     ppapi/proxy/ppb_graphics_2d_proxy.h
>>  M     ppapi/proxy/ppb_graphics_2d_proxy.cc
>>  M     ppapi/proxy/ppb_image_data_proxy.h
>>  M     ppapi/proxy/ppb_image_data_proxy.cc
>>  M     ppapi/proxy/ppb_instance_proxy.h
>>  M     ppapi/proxy/ppb_instance_proxy.cc
>>  M     ppapi/proxy/ppb_pdf_proxy.h
>>  M     ppapi/proxy/ppb_pdf_proxy.cc
>>  M     ppapi/proxy/ppb_testing_proxy.h
>>  M     ppapi/proxy/ppb_testing_proxy.cc
>>  M     ppapi/proxy/ppb_url_loader_proxy.h
>>  M     ppapi/proxy/ppb_url_loader_proxy.cc
>>  M     ppapi/proxy/ppb_url_request_info_proxy.h
>>  M     ppapi/proxy/ppb_url_request_info_proxy.cc
>>  M     ppapi/proxy/ppb_url_response_info_proxy.h
>>  M     ppapi/proxy/ppb_url_response_info_proxy.cc
>>  M     ppapi/proxy/ppb_var_deprecated_proxy.h
>>  M     ppapi/proxy/ppb_var_deprecated_proxy.cc
>>  M     ppapi/proxy/ppp_class_proxy.h
>>  M     ppapi/proxy/ppp_class_proxy.cc
>>  M     ppapi/proxy/ppp_instance_proxy.h
>>  M     ppapi/proxy/ppp_instance_proxy.cc
>>
>>
>>
>

[darin (slow to review), 2011-01-03 21:21:37]

So, we wouldn't want to just invent more message classes?  Instead of having
listeners decide if they handle a message, we could just have a single
listener per message class.

-Darin


On Sun, Dec 26, 2010 at 1:43 PM, John Abd-El-Malek <jam@chromium.org> wrote:

> This is orthogonal to the filter (which I only kept in chrome\browser, so
> that it uses BrowserThread) case.  I found a lot of existing code, and
> potential for a lot more, in places like RenderView and RenderViewHost that
> want to filter messages on the main thread.  Rather than add a new interface
> that is almost like IPC::Channel::Listener just to get a return value of
> whether a message was processed or not, I figured we can have these two
> classes keep a collection of Listener objects.
>
> On Sat, Dec 25, 2010 at 2:31 PM, Darin Fisher <darin@chromium.org> wrote:
>
>> Can you say more about how this will be used?  I'm interested, because I
>> originally resisted adding a boolean return value here.  If it is used to
>> implement message filters, then what about the case where a particular
>> listener wants to handle IPCs on a separate thread?
>>
>> -Darin
>>
>>
>>
>> On Thu, Dec 23, 2010 at 10:18 PM, <jam@chromium.org> wrote:
>>
>>> Reviewers: brettw,
>>>
>>> Message:
>>> This is the change we discussed.  I'm going to check it in as TBR while
>>> the tree
>>> is unused, given how many files this touches.
>>>
>>> Description:
>>> Make IPC::Channel::Listener:OnMessageReceived have a return value
>>> indicating
>>> whether a message was processed or not.
>>>
>>> TBR=brettw
>>>
>>> Please review this at http://codereview.chromium.org/5978003/
>>>
>>> SVN Base: svn://chrome-svn/chrome/trunk/src/
>>>
>>> Affected files:
>>>  M     chrome/browser/appcache/appcache_dispatcher_host.cc
>>>  M     chrome/browser/automation/automation_provider.h
>>>  M     chrome/browser/automation/automation_provider.cc
>>>  M     chrome/browser/automation/chrome_frame_automation_provider.h
>>>  M     chrome/browser/automation/chrome_frame_automation_provider.cc
>>>  M     chrome/browser/automation/testing_automation_provider.h
>>>  M     chrome/browser/automation/testing_automation_provider.cc
>>>  M     chrome/browser/gpu_process_host.h
>>>  M     chrome/browser/gpu_process_host.cc
>>>  M     chrome/browser/gpu_process_host_ui_shim.h
>>>  M     chrome/browser/gpu_process_host_ui_shim.cc
>>>  M     chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
>>>  M     chrome/browser/nacl_host/nacl_broker_host_win.h
>>>  M     chrome/browser/nacl_host/nacl_broker_host_win.cc
>>>  M     chrome/browser/nacl_host/nacl_process_host.h
>>>  M     chrome/browser/nacl_host/nacl_process_host.cc
>>>  M     chrome/browser/plugin_data_remover.h
>>>  M     chrome/browser/plugin_data_remover.cc
>>>  M     chrome/browser/plugin_process_host.h
>>>  M     chrome/browser/plugin_process_host.cc
>>>  M     chrome/browser/ppapi_plugin_process_host.h
>>>  M     chrome/browser/ppapi_plugin_process_host.cc
>>>  M     chrome/browser/profile_import_process_host.h
>>>  M     chrome/browser/profile_import_process_host.cc
>>>  M     chrome/browser/renderer_host/browser_render_process_host.h
>>>  M     chrome/browser/renderer_host/browser_render_process_host.cc
>>>  M     chrome/browser/renderer_host/mock_render_process_host.h
>>>  M     chrome/browser/renderer_host/mock_render_process_host.cc
>>>  M     chrome/browser/renderer_host/render_view_host.h
>>>  M     chrome/browser/renderer_host/render_view_host.cc
>>>  M     chrome/browser/renderer_host/render_widget_host.h
>>>  M     chrome/browser/renderer_host/render_widget_host.cc
>>>  M     chrome/browser/renderer_host/test/test_render_view_host.h
>>>  M     chrome/browser/renderer_host/test/test_render_view_host.cc
>>>  M     chrome/browser/service/service_process_control.h
>>>  M     chrome/browser/service/service_process_control.cc
>>>  M     chrome/browser/utility_process_host.h
>>>  M     chrome/browser/utility_process_host.cc
>>>  M     chrome/browser/worker_host/worker_process_host.h
>>>  M     chrome/browser/worker_host/worker_process_host.cc
>>>  M     chrome/common/appcache/appcache_dispatcher.h
>>>  M     chrome/common/child_process_host.h
>>>  M     chrome/common/child_process_host.cc
>>>  M     chrome/common/child_thread.h
>>>  M     chrome/common/child_thread.cc
>>>  M     chrome/common/file_system/file_system_dispatcher.h
>>>  M     chrome/common/message_router.h
>>>  M     chrome/common/message_router.cc
>>>  M     chrome/common/resource_dispatcher.h
>>>  M     chrome/common/socket_stream_dispatcher.h
>>>  M     chrome/common/webmessageportchannel_impl.h
>>>  M     chrome/common/webmessageportchannel_impl.cc
>>>  M     chrome/gpu/gpu_channel.h
>>>  M     chrome/gpu/gpu_channel.cc
>>>  M     chrome/gpu/gpu_command_buffer_stub.h
>>>  M     chrome/gpu/gpu_command_buffer_stub.cc
>>>  M     chrome/gpu/gpu_thread.h
>>>  M     chrome/gpu/gpu_thread.cc
>>>  M     chrome/gpu/gpu_video_decoder.h
>>>  M     chrome/gpu/gpu_video_decoder.cc
>>>  M     chrome/gpu/gpu_video_service.h
>>>  M     chrome/gpu/gpu_video_service.cc
>>>  M     chrome/nacl/broker_thread.h
>>>  M     chrome/nacl/broker_thread.cc
>>>  M     chrome/nacl/nacl_thread.h
>>>  M     chrome/nacl/nacl_thread.cc
>>>  M     chrome/plugin/command_buffer_stub.h
>>>  M     chrome/plugin/command_buffer_stub.cc
>>>  M     chrome/plugin/npobject_proxy.h
>>>  M     chrome/plugin/npobject_proxy.cc
>>>  M     chrome/plugin/npobject_stub.h
>>>  M     chrome/plugin/npobject_stub.cc
>>>  M     chrome/plugin/plugin_channel.h
>>>  M     chrome/plugin/plugin_channel.cc
>>>  M     chrome/plugin/plugin_channel_base.h
>>>  M     chrome/plugin/plugin_channel_base.cc
>>>  M     chrome/plugin/plugin_thread.h
>>>  M     chrome/plugin/plugin_thread.cc
>>>  M     chrome/plugin/webplugin_delegate_stub.h
>>>  M     chrome/plugin/webplugin_delegate_stub.cc
>>>  M     chrome/ppapi_plugin/ppapi_thread.h
>>>  M     chrome/ppapi_plugin/ppapi_thread.cc
>>>  M     chrome/profile_import/profile_import_thread.h
>>>  M     chrome/profile_import/profile_import_thread.cc
>>>  M     chrome/renderer/command_buffer_proxy.h
>>>  M     chrome/renderer/command_buffer_proxy.cc
>>>  M     chrome/renderer/device_orientation_dispatcher.h
>>>  M     chrome/renderer/devtools_agent.h
>>>  M     chrome/renderer/devtools_client.h
>>>  M     chrome/renderer/geolocation_dispatcher_old.h
>>>  M     chrome/renderer/gpu_channel_host.h
>>>  M     chrome/renderer/gpu_channel_host.cc
>>>  M     chrome/renderer/gpu_video_decoder_host.h
>>>  M     chrome/renderer/gpu_video_decoder_host.cc
>>>  M     chrome/renderer/indexed_db_dispatcher.h
>>>  M     chrome/renderer/mock_render_thread.h
>>>  M     chrome/renderer/mock_render_thread.cc
>>>  M     chrome/renderer/notification_provider.h
>>>  M     chrome/renderer/plugin_channel_host.h
>>>  M     chrome/renderer/plugin_channel_host.cc
>>>  M     chrome/renderer/render_thread.h
>>>  M     chrome/renderer/render_thread.cc
>>>  M     chrome/renderer/render_view.h
>>>  M     chrome/renderer/render_view.cc
>>>  M     chrome/renderer/render_widget.h
>>>  M     chrome/renderer/render_widget.cc
>>>  M     chrome/renderer/renderer_main_unittest.cc
>>>  M
>>> chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
>>>  M     chrome/renderer/safe_browsing/render_view_fake_resources_test.h
>>>  M     chrome/renderer/safe_browsing/render_view_fake_resources_test.cc
>>>  M     chrome/renderer/speech_input_dispatcher.h
>>>  M     chrome/renderer/webplugin_delegate_proxy.h
>>>  M     chrome/renderer/webplugin_delegate_proxy.cc
>>>  M     chrome/renderer/websharedworker_proxy.h
>>>  M     chrome/renderer/websharedworker_proxy.cc
>>>  M     chrome/renderer/webworker_proxy.h
>>>  M     chrome/renderer/webworker_proxy.cc
>>>  M     chrome/service/service_ipc_server.h
>>>  M     chrome/service/service_ipc_server.cc
>>>  M     chrome/service/service_utility_process_host.h
>>>  M     chrome/service/service_utility_process_host.cc
>>>  M     chrome/test/automation/automation_proxy.h
>>>  M     chrome/test/automation/automation_proxy.cc
>>>  M     chrome/test/automation/automation_proxy_uitest.h
>>>  M     chrome/test/automation/automation_proxy_uitest.cc
>>>  M     chrome/test/automation/tab_proxy.h
>>>  M     chrome/test/automation/tab_proxy.cc
>>>  M     chrome/utility/utility_thread.h
>>>  M     chrome/utility/utility_thread.cc
>>>  M     chrome/worker/websharedworker_stub.h
>>>  M     chrome/worker/websharedworker_stub.cc
>>>  M     chrome/worker/webworker_stub.h
>>>  M     chrome/worker/webworker_stub.cc
>>>  M     chrome/worker/worker_thread.h
>>>  M     chrome/worker/worker_thread.cc
>>>  M     chrome_frame/cfproxy.h
>>>  M     chrome_frame/cfproxy_private.h
>>>  M     chrome_frame/cfproxy_proxy.cc
>>>  M     chrome_frame/cfproxy_test.cc
>>>  M     chrome_frame/chrome_frame_delegate.h
>>>  M     chrome_frame/chrome_frame_delegate.cc
>>>  M     chrome_frame/external_tab.h
>>>  M     chrome_frame/external_tab.cc
>>>  M     chrome_frame/test/net/test_automation_provider.h
>>>  M     chrome_frame/test/net/test_automation_provider.cc
>>>  M     ipc/ipc_channel.h
>>>  M     ipc/ipc_channel_posix_unittest.cc
>>>  M     ipc/ipc_channel_proxy.h
>>>  M     ipc/ipc_channel_proxy.cc
>>>  M     ipc/ipc_fuzzing_tests.cc
>>>  M     ipc/ipc_message_macros.h
>>>  M     ipc/ipc_send_fds_test.cc
>>>  M     ipc/ipc_sync_channel.h
>>>  M     ipc/ipc_sync_channel.cc
>>>  M     ipc/ipc_sync_channel_unittest.cc
>>>  M     ipc/ipc_sync_message_unittest.cc
>>>  M     ipc/ipc_tests.cc
>>>  M     ipc/sync_socket_unittest.cc
>>>  M     ppapi/proxy/dispatcher.h
>>>  M     ppapi/proxy/dispatcher.cc
>>>  M     ppapi/proxy/interface_proxy.h
>>>  M     ppapi/proxy/plugin_dispatcher.h
>>>  M     ppapi/proxy/plugin_dispatcher.cc
>>>  M     ppapi/proxy/ppb_audio_config_proxy.h
>>>  M     ppapi/proxy/ppb_audio_config_proxy.cc
>>>  M     ppapi/proxy/ppb_audio_proxy.h
>>>  M     ppapi/proxy/ppb_audio_proxy.cc
>>>  M     ppapi/proxy/ppb_buffer_proxy.h
>>>  M     ppapi/proxy/ppb_buffer_proxy.cc
>>>  M     ppapi/proxy/ppb_char_set_proxy.h
>>>  M     ppapi/proxy/ppb_char_set_proxy.cc
>>>  M     ppapi/proxy/ppb_core_proxy.h
>>>  M     ppapi/proxy/ppb_core_proxy.cc
>>>  M     ppapi/proxy/ppb_cursor_control_proxy.h
>>>  M     ppapi/proxy/ppb_cursor_control_proxy.cc
>>>  M     ppapi/proxy/ppb_flash_proxy.h
>>>  M     ppapi/proxy/ppb_flash_proxy.cc
>>>  M     ppapi/proxy/ppb_font_proxy.h
>>>  M     ppapi/proxy/ppb_font_proxy.cc
>>>  M     ppapi/proxy/ppb_fullscreen_proxy.h
>>>  M     ppapi/proxy/ppb_fullscreen_proxy.cc
>>>  M     ppapi/proxy/ppb_graphics_2d_proxy.h
>>>  M     ppapi/proxy/ppb_graphics_2d_proxy.cc
>>>  M     ppapi/proxy/ppb_image_data_proxy.h
>>>  M     ppapi/proxy/ppb_image_data_proxy.cc
>>>  M     ppapi/proxy/ppb_instance_proxy.h
>>>  M     ppapi/proxy/ppb_instance_proxy.cc
>>>  M     ppapi/proxy/ppb_pdf_proxy.h
>>>  M     ppapi/proxy/ppb_pdf_proxy.cc
>>>  M     ppapi/proxy/ppb_testing_proxy.h
>>>  M     ppapi/proxy/ppb_testing_proxy.cc
>>>  M     ppapi/proxy/ppb_url_loader_proxy.h
>>>  M     ppapi/proxy/ppb_url_loader_proxy.cc
>>>  M     ppapi/proxy/ppb_url_request_info_proxy.h
>>>  M     ppapi/proxy/ppb_url_request_info_proxy.cc
>>>  M     ppapi/proxy/ppb_url_response_info_proxy.h
>>>  M     ppapi/proxy/ppb_url_response_info_proxy.cc
>>>  M     ppapi/proxy/ppb_var_deprecated_proxy.h
>>>  M     ppapi/proxy/ppb_var_deprecated_proxy.cc
>>>  M     ppapi/proxy/ppp_class_proxy.h
>>>  M     ppapi/proxy/ppp_class_proxy.cc
>>>  M     ppapi/proxy/ppp_instance_proxy.h
>>>  M     ppapi/proxy/ppp_instance_proxy.cc
>>>
>>>
>>>
>>
>

[jam, 2011-01-04 19:47:16]

I think it's nice to have IPC message filtering work the same on all
threads.  On the IO thread, we don't just call all filters, but we expect
filters to tell us when they dispatched a message so that we stop.  Why
should the UI thread be different?

On Mon, Jan 3, 2011 at 1:21 PM, Darin Fisher <darin@chromium.org> wrote:

> So, we wouldn't want to just invent more message classes?  Instead of
> having listeners decide if they handle a message, we could just have a
> single listener per message class.
>
> -Darin
>
>
> On Sun, Dec 26, 2010 at 1:43 PM, John Abd-El-Malek <jam@chromium.org>wrote:
>
>> This is orthogonal to the filter (which I only kept in chrome\browser, so
>> that it uses BrowserThread) case.  I found a lot of existing code, and
>> potential for a lot more, in places like RenderView and RenderViewHost that
>> want to filter messages on the main thread.  Rather than add a new interface
>> that is almost like IPC::Channel::Listener just to get a return value of
>> whether a message was processed or not, I figured we can have these two
>> classes keep a collection of Listener objects.
>>
>> On Sat, Dec 25, 2010 at 2:31 PM, Darin Fisher <darin@chromium.org> wrote:
>>
>>> Can you say more about how this will be used?  I'm interested, because I
>>> originally resisted adding a boolean return value here.  If it is used to
>>> implement message filters, then what about the case where a particular
>>> listener wants to handle IPCs on a separate thread?
>>>
>>> -Darin
>>>
>>>
>>>
>>> On Thu, Dec 23, 2010 at 10:18 PM, <jam@chromium.org> wrote:
>>>
>>>> Reviewers: brettw,
>>>>
>>>> Message:
>>>> This is the change we discussed.  I'm going to check it in as TBR while
>>>> the tree
>>>> is unused, given how many files this touches.
>>>>
>>>> Description:
>>>> Make IPC::Channel::Listener:OnMessageReceived have a return value
>>>> indicating
>>>> whether a message was processed or not.
>>>>
>>>> TBR=brettw
>>>>
>>>> Please review this at http://codereview.chromium.org/5978003/
>>>>
>>>> SVN Base: svn://chrome-svn/chrome/trunk/src/
>>>>
>>>> Affected files:
>>>>  M     chrome/browser/appcache/appcache_dispatcher_host.cc
>>>>  M     chrome/browser/automation/automation_provider.h
>>>>  M     chrome/browser/automation/automation_provider.cc
>>>>  M     chrome/browser/automation/chrome_frame_automation_provider.h
>>>>  M     chrome/browser/automation/chrome_frame_automation_provider.cc
>>>>  M     chrome/browser/automation/testing_automation_provider.h
>>>>  M     chrome/browser/automation/testing_automation_provider.cc
>>>>  M     chrome/browser/gpu_process_host.h
>>>>  M     chrome/browser/gpu_process_host.cc
>>>>  M     chrome/browser/gpu_process_host_ui_shim.h
>>>>  M     chrome/browser/gpu_process_host_ui_shim.cc
>>>>  M     chrome/browser/importer/firefox_importer_unittest_utils_mac.cc
>>>>  M     chrome/browser/nacl_host/nacl_broker_host_win.h
>>>>  M     chrome/browser/nacl_host/nacl_broker_host_win.cc
>>>>  M     chrome/browser/nacl_host/nacl_process_host.h
>>>>  M     chrome/browser/nacl_host/nacl_process_host.cc
>>>>  M     chrome/browser/plugin_data_remover.h
>>>>  M     chrome/browser/plugin_data_remover.cc
>>>>  M     chrome/browser/plugin_process_host.h
>>>>  M     chrome/browser/plugin_process_host.cc
>>>>  M     chrome/browser/ppapi_plugin_process_host.h
>>>>  M     chrome/browser/ppapi_plugin_process_host.cc
>>>>  M     chrome/browser/profile_import_process_host.h
>>>>  M     chrome/browser/profile_import_process_host.cc
>>>>  M     chrome/browser/renderer_host/browser_render_process_host.h
>>>>  M     chrome/browser/renderer_host/browser_render_process_host.cc
>>>>  M     chrome/browser/renderer_host/mock_render_process_host.h
>>>>  M     chrome/browser/renderer_host/mock_render_process_host.cc
>>>>  M     chrome/browser/renderer_host/render_view_host.h
>>>>  M     chrome/browser/renderer_host/render_view_host.cc
>>>>  M     chrome/browser/renderer_host/render_widget_host.h
>>>>  M     chrome/browser/renderer_host/render_widget_host.cc
>>>>  M     chrome/browser/renderer_host/test/test_render_view_host.h
>>>>  M     chrome/browser/renderer_host/test/test_render_view_host.cc
>>>>  M     chrome/browser/service/service_process_control.h
>>>>  M     chrome/browser/service/service_process_control.cc
>>>>  M     chrome/browser/utility_process_host.h
>>>>  M     chrome/browser/utility_process_host.cc
>>>>  M     chrome/browser/worker_host/worker_process_host.h
>>>>  M     chrome/browser/worker_host/worker_process_host.cc
>>>>  M     chrome/common/appcache/appcache_dispatcher.h
>>>>  M     chrome/common/child_process_host.h
>>>>  M     chrome/common/child_process_host.cc
>>>>  M     chrome/common/child_thread.h
>>>>  M     chrome/common/child_thread.cc
>>>>  M     chrome/common/file_system/file_system_dispatcher.h
>>>>  M     chrome/common/message_router.h
>>>>  M     chrome/common/message_router.cc
>>>>  M     chrome/common/resource_dispatcher.h
>>>>  M     chrome/common/socket_stream_dispatcher.h
>>>>  M     chrome/common/webmessageportchannel_impl.h
>>>>  M     chrome/common/webmessageportchannel_impl.cc
>>>>  M     chrome/gpu/gpu_channel.h
>>>>  M     chrome/gpu/gpu_channel.cc
>>>>  M     chrome/gpu/gpu_command_buffer_stub.h
>>>>  M     chrome/gpu/gpu_command_buffer_stub.cc
>>>>  M     chrome/gpu/gpu_thread.h
>>>>  M     chrome/gpu/gpu_thread.cc
>>>>  M     chrome/gpu/gpu_video_decoder.h
>>>>  M     chrome/gpu/gpu_video_decoder.cc
>>>>  M     chrome/gpu/gpu_video_service.h
>>>>  M     chrome/gpu/gpu_video_service.cc
>>>>  M     chrome/nacl/broker_thread.h
>>>>  M     chrome/nacl/broker_thread.cc
>>>>  M     chrome/nacl/nacl_thread.h
>>>>  M     chrome/nacl/nacl_thread.cc
>>>>  M     chrome/plugin/command_buffer_stub.h
>>>>  M     chrome/plugin/command_buffer_stub.cc
>>>>  M     chrome/plugin/npobject_proxy.h
>>>>  M     chrome/plugin/npobject_proxy.cc
>>>>  M     chrome/plugin/npobject_stub.h
>>>>  M     chrome/plugin/npobject_stub.cc
>>>>  M     chrome/plugin/plugin_channel.h
>>>>  M     chrome/plugin/plugin_channel.cc
>>>>  M     chrome/plugin/plugin_channel_base.h
>>>>  M     chrome/plugin/plugin_channel_base.cc
>>>>  M     chrome/plugin/plugin_thread.h
>>>>  M     chrome/plugin/plugin_thread.cc
>>>>  M     chrome/plugin/webplugin_delegate_stub.h
>>>>  M     chrome/plugin/webplugin_delegate_stub.cc
>>>>  M     chrome/ppapi_plugin/ppapi_thread.h
>>>>  M     chrome/ppapi_plugin/ppapi_thread.cc
>>>>  M     chrome/profile_import/profile_import_thread.h
>>>>  M     chrome/profile_import/profile_import_thread.cc
>>>>  M     chrome/renderer/command_buffer_proxy.h
>>>>  M     chrome/renderer/command_buffer_proxy.cc
>>>>  M     chrome/renderer/device_orientation_dispatcher.h
>>>>  M     chrome/renderer/devtools_agent.h
>>>>  M     chrome/renderer/devtools_client.h
>>>>  M     chrome/renderer/geolocation_dispatcher_old.h
>>>>  M     chrome/renderer/gpu_channel_host.h
>>>>  M     chrome/renderer/gpu_channel_host.cc
>>>>  M     chrome/renderer/gpu_video_decoder_host.h
>>>>  M     chrome/renderer/gpu_video_decoder_host.cc
>>>>  M     chrome/renderer/indexed_db_dispatcher.h
>>>>  M     chrome/renderer/mock_render_thread.h
>>>>  M     chrome/renderer/mock_render_thread.cc
>>>>  M     chrome/renderer/notification_provider.h
>>>>  M     chrome/renderer/plugin_channel_host.h
>>>>  M     chrome/renderer/plugin_channel_host.cc
>>>>  M     chrome/renderer/render_thread.h
>>>>  M     chrome/renderer/render_thread.cc
>>>>  M     chrome/renderer/render_view.h
>>>>  M     chrome/renderer/render_view.cc
>>>>  M     chrome/renderer/render_widget.h
>>>>  M     chrome/renderer/render_widget.cc
>>>>  M     chrome/renderer/renderer_main_unittest.cc
>>>>  M
>>>> chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
>>>>  M     chrome/renderer/safe_browsing/render_view_fake_resources_test.h
>>>>  M     chrome/renderer/safe_browsing/render_view_fake_resources_test.cc
>>>>  M     chrome/renderer/speech_input_dispatcher.h
>>>>  M     chrome/renderer/webplugin_delegate_proxy.h
>>>>  M     chrome/renderer/webplugin_delegate_proxy.cc
>>>>  M     chrome/renderer/websharedworker_proxy.h
>>>>  M     chrome/renderer/websharedworker_proxy.cc
>>>>  M     chrome/renderer/webworker_proxy.h
>>>>  M     chrome/renderer/webworker_proxy.cc
>>>>  M     chrome/service/service_ipc_server.h
>>>>  M     chrome/service/service_ipc_server.cc
>>>>  M     chrome/service/service_utility_process_host.h
>>>>  M     chrome/service/service_utility_process_host.cc
>>>>  M     chrome/test/automation/automation_proxy.h
>>>>  M     chrome/test/automation/automation_proxy.cc
>>>>  M     chrome/test/automation/automation_proxy_uitest.h
>>>>  M     chrome/test/automation/automation_proxy_uitest.cc
>>>>  M     chrome/test/automation/tab_proxy.h
>>>>  M     chrome/test/automation/tab_proxy.cc
>>>>  M     chrome/utility/utility_thread.h
>>>>  M     chrome/utility/utility_thread.cc
>>>>  M     chrome/worker/websharedworker_stub.h
>>>>  M     chrome/worker/websharedworker_stub.cc
>>>>  M     chrome/worker/webworker_stub.h
>>>>  M     chrome/worker/webworker_stub.cc
>>>>  M     chrome/worker/worker_thread.h
>>>>  M     chrome/worker/worker_thread.cc
>>>>  M     chrome_frame/cfproxy.h
>>>>  M     chrome_frame/cfproxy_private.h
>>>>  M     chrome_frame/cfproxy_proxy.cc
>>>>  M     chrome_frame/cfproxy_test.cc
>>>>  M     chrome_frame/chrome_frame_delegate.h
>>>>  M     chrome_frame/chrome_frame_delegate.cc
>>>>  M     chrome_frame/external_tab.h
>>>>  M     chrome_frame/external_tab.cc
>>>>  M     chrome_frame/test/net/test_automation_provider.h
>>>>  M     chrome_frame/test/net/test_automation_provider.cc
>>>>  M     ipc/ipc_channel.h
>>>>  M     ipc/ipc_channel_posix_unittest.cc
>>>>  M     ipc/ipc_channel_proxy.h
>>>>  M     ipc/ipc_channel_proxy.cc
>>>>  M     ipc/ipc_fuzzing_tests.cc
>>>>  M     ipc/ipc_message_macros.h
>>>>  M     ipc/ipc_send_fds_test.cc
>>>>  M     ipc/ipc_sync_channel.h
>>>>  M     ipc/ipc_sync_channel.cc
>>>>  M     ipc/ipc_sync_channel_unittest.cc
>>>>  M     ipc/ipc_sync_message_unittest.cc
>>>>  M     ipc/ipc_tests.cc
>>>>  M     ipc/sync_socket_unittest.cc
>>>>  M     ppapi/proxy/dispatcher.h
>>>>  M     ppapi/proxy/dispatcher.cc
>>>>  M     ppapi/proxy/interface_proxy.h
>>>>  M     ppapi/proxy/plugin_dispatcher.h
>>>>  M     ppapi/proxy/plugin_dispatcher.cc
>>>>  M     ppapi/proxy/ppb_audio_config_proxy.h
>>>>  M     ppapi/proxy/ppb_audio_config_proxy.cc
>>>>  M     ppapi/proxy/ppb_audio_proxy.h
>>>>  M     ppapi/proxy/ppb_audio_proxy.cc
>>>>  M     ppapi/proxy/ppb_buffer_proxy.h
>>>>  M     ppapi/proxy/ppb_buffer_proxy.cc
>>>>  M     ppapi/proxy/ppb_char_set_proxy.h
>>>>  M     ppapi/proxy/ppb_char_set_proxy.cc
>>>>  M     ppapi/proxy/ppb_core_proxy.h
>>>>  M     ppapi/proxy/ppb_core_proxy.cc
>>>>  M     ppapi/proxy/ppb_cursor_control_proxy.h
>>>>  M     ppapi/proxy/ppb_cursor_control_proxy.cc
>>>>  M     ppapi/proxy/ppb_flash_proxy.h
>>>>  M     ppapi/proxy/ppb_flash_proxy.cc
>>>>  M     ppapi/proxy/ppb_font_proxy.h
>>>>  M     ppapi/proxy/ppb_font_proxy.cc
>>>>  M     ppapi/proxy/ppb_fullscreen_proxy.h
>>>>  M     ppapi/proxy/ppb_fullscreen_proxy.cc
>>>>  M     ppapi/proxy/ppb_graphics_2d_proxy.h
>>>>  M     ppapi/proxy/ppb_graphics_2d_proxy.cc
>>>>  M     ppapi/proxy/ppb_image_data_proxy.h
>>>>  M     ppapi/proxy/ppb_image_data_proxy.cc
>>>>  M     ppapi/proxy/ppb_instance_proxy.h
>>>>  M     ppapi/proxy/ppb_instance_proxy.cc
>>>>  M     ppapi/proxy/ppb_pdf_proxy.h
>>>>  M     ppapi/proxy/ppb_pdf_proxy.cc
>>>>  M     ppapi/proxy/ppb_testing_proxy.h
>>>>  M     ppapi/proxy/ppb_testing_proxy.cc
>>>>  M     ppapi/proxy/ppb_url_loader_proxy.h
>>>>  M     ppapi/proxy/ppb_url_loader_proxy.cc
>>>>  M     ppapi/proxy/ppb_url_request_info_proxy.h
>>>>  M     ppapi/proxy/ppb_url_request_info_proxy.cc
>>>>  M     ppapi/proxy/ppb_url_response_info_proxy.h
>>>>  M     ppapi/proxy/ppb_url_response_info_proxy.cc
>>>>  M     ppapi/proxy/ppb_var_deprecated_proxy.h
>>>>  M     ppapi/proxy/ppb_var_deprecated_proxy.cc
>>>>  M     ppapi/proxy/ppp_class_proxy.h
>>>>  M     ppapi/proxy/ppp_class_proxy.cc
>>>>  M     ppapi/proxy/ppp_instance_proxy.h
>>>>  M     ppapi/proxy/ppp_instance_proxy.cc
>>>>
>>>>
>>>>
>>>
>>
>