Make IPC::Channel::Listener:OnMessageReceived have a return value indicating ...

chrome/test/automation/automation_proxy.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/automation/automation_proxy.h"
 
 #include <gtest/gtest.h>
 
 #include <sstream>
 
@@ skipping 24 matching lines @@
 // This object allows messages received on the background thread to be
 // properly triaged.
 class AutomationMessageFilter : public IPC::ChannelProxy::MessageFilter {
  public:
   explicit AutomationMessageFilter(AutomationProxy* server) : server_(server) {}
 
   // Return true to indicate that the message was handled, or false to let
   // the message be handled in the default way.
   virtual bool OnMessageReceived(const IPC::Message& message) {
     bool handled = true;
-
     IPC_BEGIN_MESSAGE_MAP(AutomationMessageFilter, message)
       IPC_MESSAGE_HANDLER_GENERIC(AutomationMsg_Hello,
-                                  OnAutomationHello(message));
+                                  OnAutomationHello(message))
       IPC_MESSAGE_HANDLER_GENERIC(
-        AutomationMsg_InitialLoadsComplete, server_->SignalInitialLoads());
+        AutomationMsg_InitialLoadsComplete, server_->SignalInitialLoads())
       IPC_MESSAGE_HANDLER(AutomationMsg_InitialNewTabUILoadComplete,
-                          NewTabLoaded);
+                          NewTabLoaded)
       IPC_MESSAGE_HANDLER_GENERIC(
-        AutomationMsg_InvalidateHandle, server_->InvalidateHandle(message));
-      IPC_MESSAGE_UNHANDLED(handled = false);
+        AutomationMsg_InvalidateHandle, server_->InvalidateHandle(message))
+      IPC_MESSAGE_UNHANDLED(handled = false)
     IPC_END_MESSAGE_MAP()
 
     return handled;
   }
 
   virtual void OnFilterAdded(IPC::Channel* channel) {
     server_->SetChannel(channel);
   }
 
   virtual void OnFilterRemoved() {
@@ skipping 306 matching lines @@
 bool AutomationProxy::SendProxyConfig(const std::string& new_proxy_config) {
   return Send(new AutomationMsg_SetProxyConfig(new_proxy_config));
 }
 
 void AutomationProxy::Disconnect() {
   DCHECK(shutdown_event_.get() != NULL);
   shutdown_event_->Signal();
   channel_.reset();
 }
 
-void AutomationProxy::OnMessageReceived(const IPC::Message& msg) {
+bool AutomationProxy::OnMessageReceived(const IPC::Message& msg) {
   // This won't get called unless AutomationProxy is run from
   // inside a message loop.
   NOTREACHED();
+  return false;
 }
 
 void AutomationProxy::OnChannelError() {
   LOG(ERROR) << "Channel error in AutomationProxy.";
   if (disconnect_on_failure_)
     Disconnect();
 }
 
 scoped_refptr<WindowProxy> AutomationProxy::GetActiveWindow() {
   int handle = 0;
@@ skipping 144 matching lines @@
                                                           password,
                                                           &success));
   // If message sending unsuccessful or test failed, return false.
   return sent && success;
 }
 #endif
 
 bool AutomationProxy::ResetToDefaultTheme() {
   return Send(new AutomationMsg_ResetToDefaultTheme());
 }