chrome/browser/automation/chrome_frame_automation_provider.cc - Issue 5978003: Make IPC::Channel::Listener:OnMessageReceived have a return value indicating ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/chrome_frame_automation_provider.cc

Issue 5978003: Make IPC::Channel::Listener:OnMessageReceived have a return value indicating ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/chrome_frame_automation_provider.h ('k') | chrome/browser/automation/testing_automation_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/chrome_frame_automation_provider.cc

===================================================================

--- chrome/browser/automation/chrome_frame_automation_provider.cc (revision 70108)

+++ chrome/browser/automation/chrome_frame_automation_provider.cc (working copy)

@@ -12,13 +12,13 @@

ChromeFrameAutomationProvider::ChromeFrameAutomationProvider(Profile* profile)

: AutomationProvider(profile) {}

-void ChromeFrameAutomationProvider::OnMessageReceived(

+bool ChromeFrameAutomationProvider::OnMessageReceived(

const IPC::Message& message) {

- if (IsValidMessage(message.type())) {

- AutomationProvider::OnMessageReceived(message);

- } else {

- OnUnhandledMessage(message);

- }

+ if (IsValidMessage(message.type()))

+ return AutomationProvider::OnMessageReceived(message);

+ OnUnhandledMessage(message);

+ return false;

}

void ChromeFrameAutomationProvider::OnUnhandledMessage(