Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 5977010: Move CancellationFlag and WaitableEvent to the synchronization subdirectory.... (Closed)

Created:
9 years, 11 months ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), amit, annacc, stuartmorgan+watch_chromium.org, Ilya Sherman, dhollowa, cbentzel+watch_chromium.org, Alpha Left Google, Erik does not do reviews, jam, acolwell GONE FROM CHROMIUM, darin-cc_chromium.org, garykac, brettw-cc_chromium.org, tim (not reviewing), ddorwin+watch_chromium.org, Raghu Simha, ncarter (slow), pam+watch_chromium.org, awong, James Hawkins, scherkus (not reviewing), michaeln, sjl, Sergey Ulanov, idana, Aaron Boodman, dmac, Paweł Hajdan Jr.
Visibility:
Public.

Description

Move CancellationFlag and WaitableEvent to the synchronization subdirectory. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70369

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -1755 lines) Patch
M base/base.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M base/base.gypi View 4 chunks +8 lines, -8 lines 0 comments Download
D base/cancellation_flag.h View 1 chunk +0 lines, -43 lines 0 comments Download
D base/cancellation_flag.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D base/cancellation_flag_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M base/message_pump_default.h View 1 chunk +1 line, -1 line 0 comments Download
M base/process_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/synchronization/cancellation_flag.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + base/synchronization/cancellation_flag.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + base/synchronization/cancellation_flag_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
A + base/synchronization/waitable_event.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + base/synchronization/waitable_event_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
A + base/synchronization/waitable_event_unittest.cc View 4 chunks +10 lines, -13 lines 0 comments Download
A + base/synchronization/waitable_event_watcher.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + base/synchronization/waitable_event_watcher_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + base/synchronization/waitable_event_watcher_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
A + base/synchronization/waitable_event_watcher_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + base/synchronization/waitable_event_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/simple_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/simple_thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_local_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D base/waitable_event.h View 1 chunk +0 lines, -179 lines 0 comments Download
D base/waitable_event_posix.cc View 1 chunk +0 lines, -404 lines 0 comments Download
D base/waitable_event_unittest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D base/waitable_event_watcher.h View 1 chunk +0 lines, -162 lines 0 comments Download
D base/waitable_event_watcher_posix.cc View 1 chunk +0 lines, -280 lines 0 comments Download
D base/waitable_event_watcher_unittest.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D base/waitable_event_watcher_win.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D base/waitable_event_win.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M chrome/browser/aeropeek_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cancelable_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cancelable_request.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/dom_ui/bug_report_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/dom_ui_screenshot_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_path_watcher/file_path_watcher_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/in_process_webkit/indexed_db_key_utility_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_net_log_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/cookie_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/predictor_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_default_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_loader_win.h View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/policy/device_token_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_singleton_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer_thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/database_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/http_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/ui_model_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/child_process.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/plugin/plugin_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/cookie_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/gaia/service_gaia_authenticator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_process.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_process_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/live_sync/live_sessions_sync_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/signaling_task.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/testing_browser_process.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/thread_observer_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/thread_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/cfproxy_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/custom_sync_call_context.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/external_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/external_tab_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/proxy_factory_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_sync_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
MM media/audio/audio_input_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 chunk +1 line, -1 line 0 comments Download
M media/omx/omx_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/directory_lister.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/keygen_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mock_host_resolver.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/in_flight_io.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_service.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/sync_host_resolver_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/sync_host_resolver_bridge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/chromoting_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/jingle_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/jingle_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/jingle_glue/jingle_thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_request_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_response_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_storage_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/blob/blob_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webmediaplayer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_appcache_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR
9 years, 11 months ago (2011-01-02 06:05:23 UTC) #1
darin (slow to review)
9 years, 11 months ago (2011-01-03 21:37:51 UTC) #2
LGTM

On Sat, Jan 1, 2011 at 10:05 PM, <brettw@chromium.org> wrote:

> Reviewers: darin,
>
> Message:
> TBR
>
> Description:
> Move CancellationFlag and WaitableEvent to the synchronization
> subdirectory.
>
> TEST=it compiles
> BUG=none
>
> Please review this at http://codereview.chromium.org/5977010/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     base/base.gyp
>  M     base/base.gypi
>  D     base/cancellation_flag.h
>  D     base/cancellation_flag.cc
>  D     base/cancellation_flag_unittest.cc
>  M     base/message_pump_default.h
>  M     base/process_util_posix.cc
>  A  +  base/synchronization/cancellation_flag.h
>  A  +  base/synchronization/cancellation_flag.cc
>  A  +  base/synchronization/cancellation_flag_unittest.cc
>  A  +  base/synchronization/waitable_event.h
>  A  +  base/synchronization/waitable_event_posix.cc
>  A  +  base/synchronization/waitable_event_unittest.cc
>  A  +  base/synchronization/waitable_event_watcher.h
>  A  +  base/synchronization/waitable_event_watcher_posix.cc
>  A  +  base/synchronization/waitable_event_watcher_unittest.cc
>  A  +  base/synchronization/waitable_event_watcher_win.cc
>  A  +  base/synchronization/waitable_event_win.cc
>  M     base/threading/simple_thread.h
>  M     base/threading/simple_thread_unittest.cc
>  M     base/threading/thread.cc
>  M     base/threading/thread_local_unittest.cc
>  M     base/threading/worker_pool_posix_unittest.cc
>  M     base/threading/worker_pool_unittest.cc
>  D     base/waitable_event.h
>  D     base/waitable_event_posix.cc
>  D     base/waitable_event_unittest.cc
>  D     base/waitable_event_watcher.h
>  D     base/waitable_event_watcher_posix.cc
>  D     base/waitable_event_watcher_unittest.cc
>  D     base/waitable_event_watcher_win.cc
>  D     base/waitable_event_win.cc
>  M     chrome/browser/aeropeek_manager.cc
>  M     chrome/browser/automation/automation_provider.cc
>  M     chrome/browser/bookmarks/bookmark_model.h
>  M     chrome/browser/browser_process_impl.cc
>  M     chrome/browser/cancelable_request.h
>  M     chrome/browser/cancelable_request.cc
>  M     chrome/browser/dom_ui/bug_report_ui.cc
>  M     chrome/browser/dom_ui/dom_ui_screenshot_source.cc
>  M     chrome/browser/file_path_watcher/file_path_watcher_browsertest.cc
>  MM    chrome/browser/in_process_webkit/indexed_db_key_utility_client.h
>  M     chrome/browser/net/chrome_net_log_unittest.cc
>  M     chrome/browser/net/cookie_policy_browsertest.cc
>  M     chrome/browser/net/predictor_api.cc
>  M
> chrome/browser/notifications/desktop_notification_service_unittest.cc
>  M     chrome/browser/password_manager/native_backend_gnome_x.cc
>  M     chrome/browser/password_manager/password_store_default_unittest.cc
>  M     chrome/browser/password_manager/password_store_win_unittest.cc
>  M     chrome/browser/password_manager/password_store_x_unittest.cc
>  M     chrome/browser/plugin_service.h
>  M     chrome/browser/plugin_service.cc
>  M     chrome/browser/policy/configuration_policy_loader_win.h
>  MM    chrome/browser/policy/device_token_fetcher.h
>  M     chrome/browser/process_singleton_uitest.cc
>  M     chrome/browser/renderer_host/render_widget_helper.h
>  M     chrome/browser/sync/engine/syncer_thread.h
>  M     chrome/browser/sync/engine/syncer_thread_unittest.cc
>  M     chrome/browser/sync/glue/autofill_data_type_controller.h
>  M     chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
>  M     chrome/browser/sync/glue/database_model_worker.cc
>  M     chrome/browser/sync/glue/history_model_worker.cc
>  M     chrome/browser/sync/glue/http_bridge.h
>  M     chrome/browser/sync/glue/password_model_worker.cc
>  M     chrome/browser/sync/glue/ui_model_worker.cc
>  M     chrome/browser/sync/glue/ui_model_worker_unittest.cc
>  M     chrome/browser/sync/profile_sync_service_autofill_unittest.cc
>  M     chrome/browser/sync/profile_sync_test_util.h
>  M     chrome/browser/sync/util/extensions_activity_monitor_unittest.cc
>  M     chrome/browser/webdata/web_data_service_unittest.cc
>  M     chrome/common/child_process.h
>  M     chrome/common/net/url_fetcher_unittest.cc
>  M     chrome/plugin/plugin_channel.cc
>  M     chrome/renderer/cookie_message_filter.h
>  M     chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc
>  M     chrome/service/gaia/service_gaia_authenticator.h
>  M     chrome/service/service_process.h
>  M     chrome/service/service_process_unittest.cc
>  M     chrome/test/automation/automation_proxy.h
>  M     chrome/test/automation/automation_proxy.cc
>  M     chrome/test/live_sync/live_sessions_sync_test.h
>  M     chrome/test/live_sync/live_sync_test.cc
>  M     chrome/test/signaling_task.h
>  M     chrome/test/testing_browser_process.h
>  M     chrome/test/thread_observer_helper.h
>  M     chrome/test/thread_test_helper.h
>  M     chrome_frame/cfproxy_test.cc
>  M     chrome_frame/chrome_frame_automation.cc
>  M     chrome_frame/custom_sync_call_context.h
>  M     chrome_frame/external_tab.cc
>  M     chrome_frame/external_tab_test.cc
>  M     chrome_frame/test/proxy_factory_mock.cc
>  M     ipc/ipc_sync_channel.h
>  M     ipc/ipc_sync_channel.cc
>  M     ipc/ipc_sync_channel_unittest.cc
>  M     ipc/ipc_sync_message.cc
>  M     ipc/ipc_sync_message_filter.cc
>  MM    media/audio/audio_input_controller_unittest.cc
>  M     media/audio/audio_output_controller_unittest.cc
>  M     media/filters/ffmpeg_demuxer.h
>  M     media/omx/omx_unittest.cc
>  M     net/base/directory_lister.h
>  M     net/base/file_stream_posix.cc
>  M     net/base/keygen_handler_unittest.cc
>  M     net/base/mock_host_resolver.h
>  M     net/disk_cache/in_flight_io.h
>  M     net/proxy/multi_threaded_proxy_resolver_unittest.cc
>  M     net/proxy/proxy_config_service_linux_unittest.cc
>  M     net/proxy/proxy_service.h
>  M     net/proxy/sync_host_resolver_bridge.cc
>  M     net/proxy/sync_host_resolver_bridge_unittest.cc
>  M     remoting/client/chromoting_view.cc
>  M     remoting/jingle_glue/jingle_client_unittest.cc
>  M     remoting/jingle_glue/jingle_thread.h
>  M     remoting/jingle_glue/jingle_thread_unittest.cc
>  M     remoting/protocol/jingle_session_unittest.cc
>  M     webkit/appcache/appcache_request_handler_unittest.cc
>  M     webkit/appcache/appcache_response_unittest.cc
>  M     webkit/appcache/appcache_storage_impl_unittest.cc
>  M     webkit/appcache/appcache_update_job_unittest.cc
>  M     webkit/appcache/appcache_url_request_job_unittest.cc
>  M     webkit/blob/blob_url_request_job_unittest.cc
>  M     webkit/glue/webmediaplayer_impl.h
>  M     webkit/tools/test_shell/simple_appcache_system.cc
>  M     webkit/tools/test_shell/simple_resource_loader_bridge.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698