Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 5976009: Remove BUG= and TEST= checks from upload commit presubmit check. (Closed)

Created:
10 years ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove BUG= and TEST= checks from upload commit presubmit check. Fix PRESUBMIT.py to exclude Makefile. BUG=none TEST=presubmit check is less noisy Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71622

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M PRESUBMIT.py View 1 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
10 years ago (2010-12-23 20:26:53 UTC) #1
nsylvain
LGTM
10 years ago (2010-12-23 22:04:52 UTC) #2
commit-bot: I haz the power
Patch verification failed
10 years ago (2010-12-24 01:08:34 UTC) #3
commit-bot: I haz the power
Patch failed to apply against 70187.
9 years, 12 months ago (2010-12-27 03:23:04 UTC) #4
commit-bot: I haz the power
9 years, 11 months ago (2011-01-18 03:30:00 UTC) #5
Change committed as 71622

Powered by Google App Engine
This is Rietveld 408576698