| OLD | NEW |
| 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| 11 _EXCLUDED_PATHS = ( | 11 _EXCLUDED_PATHS = ( |
| 12 r"breakpad[\\\/].*", | 12 r"^breakpad[\\\/].*", |
| 13 r"net/tools/spdyshark/[\\\/].*", | 13 r"^net/tools/spdyshark/[\\\/].*", |
| 14 r"skia[\\\/].*", | 14 r"^skia[\\\/].*", |
| 15 r"v8[\\\/].*", | 15 r"^v8[\\\/].*", |
| 16 r".*MakeFile$", |
| 16 ) | 17 ) |
| 17 | 18 |
| 18 _TEXT_FILES = ( | 19 _TEXT_FILES = ( |
| 19 r".*\.txt", | 20 r".*\.txt", |
| 20 r".*\.json", | 21 r".*\.json", |
| 21 ) | 22 ) |
| 22 | 23 |
| 23 _LICENSE_HEADER = ( | 24 _LICENSE_HEADER = ( |
| 24 r".*? Copyright \(c\) 20[0-9\-]{2,7} The Chromium Authors\. All rights " | 25 r".*? Copyright \(c\) 20[0-9\-]{2,7} The Chromium Authors\. All rights " |
| 25 r"reserved\." "\n" | 26 r"reserved\." "\n" |
| (...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 99 white_list = input_api.DEFAULT_WHITE_LIST + _TEXT_FILES | 100 white_list = input_api.DEFAULT_WHITE_LIST + _TEXT_FILES |
| 100 sources = lambda x: input_api.FilterSourceFile(x, black_list=black_list) | 101 sources = lambda x: input_api.FilterSourceFile(x, black_list=black_list) |
| 101 text_files = lambda x: input_api.FilterSourceFile(x, black_list=black_list, | 102 text_files = lambda x: input_api.FilterSourceFile(x, black_list=black_list, |
| 102 white_list=white_list) | 103 white_list=white_list) |
| 103 results.extend(input_api.canned_checks.CheckLongLines( | 104 results.extend(input_api.canned_checks.CheckLongLines( |
| 104 input_api, output_api, source_file_filter=sources)) | 105 input_api, output_api, source_file_filter=sources)) |
| 105 results.extend(input_api.canned_checks.CheckChangeHasNoTabs( | 106 results.extend(input_api.canned_checks.CheckChangeHasNoTabs( |
| 106 input_api, output_api, source_file_filter=sources)) | 107 input_api, output_api, source_file_filter=sources)) |
| 107 results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( | 108 results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace( |
| 108 input_api, output_api, source_file_filter=sources)) | 109 input_api, output_api, source_file_filter=sources)) |
| 109 results.extend(input_api.canned_checks.CheckChangeHasBugField( | |
| 110 input_api, output_api)) | |
| 111 results.extend(input_api.canned_checks.CheckChangeHasTestField( | |
| 112 input_api, output_api)) | |
| 113 results.extend(input_api.canned_checks.CheckChangeSvnEolStyle( | 110 results.extend(input_api.canned_checks.CheckChangeSvnEolStyle( |
| 114 input_api, output_api, source_file_filter=text_files)) | 111 input_api, output_api, source_file_filter=text_files)) |
| 115 results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes( | 112 results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes( |
| 116 input_api, output_api)) | 113 input_api, output_api)) |
| 117 results.extend(input_api.canned_checks.CheckLicense( | 114 results.extend(input_api.canned_checks.CheckLicense( |
| 118 input_api, output_api, _LICENSE_HEADER, source_file_filter=sources)) | 115 input_api, output_api, _LICENSE_HEADER, source_file_filter=sources)) |
| 119 results.extend(_CheckConstNSObject( | 116 results.extend(_CheckConstNSObject( |
| 120 input_api, output_api, source_file_filter=sources)) | 117 input_api, output_api, source_file_filter=sources)) |
| 121 results.extend(_CheckSingletonInHeaders( | 118 results.extend(_CheckSingletonInHeaders( |
| 122 input_api, output_api, source_file_filter=sources)) | 119 input_api, output_api, source_file_filter=sources)) |
| (...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 164 'Chromium Arm (dbg)', | 161 'Chromium Arm (dbg)', |
| 165 'Chromium Linux', | 162 'Chromium Linux', |
| 166 'Chromium Linux x64', | 163 'Chromium Linux x64', |
| 167 ] | 164 ] |
| 168 results.extend(input_api.canned_checks.CheckBuildbotPendingBuilds( | 165 results.extend(input_api.canned_checks.CheckBuildbotPendingBuilds( |
| 169 input_api, | 166 input_api, |
| 170 output_api, | 167 output_api, |
| 171 'http://build.chromium.org/p/chromium/json/builders?filter=1', | 168 'http://build.chromium.org/p/chromium/json/builders?filter=1', |
| 172 6, | 169 6, |
| 173 IGNORED_BUILDERS)) | 170 IGNORED_BUILDERS)) |
| 171 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 172 input_api, output_api)) |
| 173 results.extend(input_api.canned_checks.CheckChangeHasTestField( |
| 174 input_api, output_api)) |
| 174 return results | 175 return results |
| 175 | 176 |
| 176 | 177 |
| 177 def GetPreferredTrySlaves(): | 178 def GetPreferredTrySlaves(): |
| 178 return ['win', 'linux', 'mac'] | 179 return ['win', 'linux', 'mac'] |
| OLD | NEW |