Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: PRESUBMIT.py

Issue 5976009: Remove BUG= and TEST= checks from upload commit presubmit check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 0cff3dee328d4fedb22762585070beac72f71bda..65df2245acad080469ceb9c7202cc7a4c2bac924 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -9,10 +9,11 @@ for more details about the presubmit API built into gcl.
"""
_EXCLUDED_PATHS = (
- r"breakpad[\\\/].*",
- r"net/tools/spdyshark/[\\\/].*",
- r"skia[\\\/].*",
- r"v8[\\\/].*",
+ r"^breakpad[\\\/].*",
+ r"^net/tools/spdyshark/[\\\/].*",
+ r"^skia[\\\/].*",
+ r"^v8[\\\/].*",
+ r".*MakeFile$",
)
_TEXT_FILES = (
@@ -106,10 +107,6 @@ def _CommonChecks(input_api, output_api):
input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
input_api, output_api, source_file_filter=sources))
- results.extend(input_api.canned_checks.CheckChangeHasBugField(
- input_api, output_api))
- results.extend(input_api.canned_checks.CheckChangeHasTestField(
- input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
input_api, output_api, source_file_filter=text_files))
results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
@@ -171,6 +168,10 @@ def CheckChangeOnCommit(input_api, output_api):
'http://build.chromium.org/p/chromium/json/builders?filter=1',
6,
IGNORED_BUILDERS))
+ results.extend(input_api.canned_checks.CheckChangeHasBugField(
+ input_api, output_api))
+ results.extend(input_api.canned_checks.CheckChangeHasTestField(
+ input_api, output_api))
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698