Change extension unload notification to indicate updates....

chrome/browser/automation/automation_extension_tracker.cc

Index: chrome/browser/automation/automation_extension_tracker.cc
===================================================================
--- chrome/browser/automation/automation_extension_tracker.cc	(revision 69996)
+++ chrome/browser/automation/automation_extension_tracker.cc	(working copy)
@@ -13,8 +13,6 @@
     : AutomationResourceTracker<const Extension*>(automation) {
   registrar_.Add(this, NotificationType::EXTENSION_UNLOADED,
                  NotificationService::AllSources());
-  registrar_.Add(this, NotificationType::EXTENSION_UNLOADED_DISABLED,
-                 NotificationService::AllSources());
 }
 
 AutomationExtensionTracker::~AutomationExtensionTracker() {
@@ -27,11 +25,11 @@
 void AutomationExtensionTracker::Observe(NotificationType type,
                                          const NotificationSource& source,
                                          const NotificationDetails& details) {
-  if (type != NotificationType::EXTENSION_UNLOADED &&
-      type != NotificationType::EXTENSION_UNLOADED_DISABLED)
+  if (type != NotificationType::EXTENSION_UNLOADED)

[Erik does not do reviews, 2010/12/23 17:05:17]

should this be NOTREACHED()?

[asargent_no_longer_on_chrome, 2010/12/23 18:53:04]

Done.

     return;
 
-  const Extension* extension = Details<const Extension>(details).ptr();
+  const Extension* extension =
+      Details<UnloadedExtensionInfo>(details)->extension;

[Erik does not do reviews, 2010/12/23 17:05:17]

extension can be NULL right?  so it looks like a crash can happen here.

[asargent_no_longer_on_chrome, 2010/12/23 18:53:04]

It turns out it can't. See my response to comments on extension.h.

   Profile* profile = Source<Profile>(source).ptr();
   if (profile) {
     ExtensionService* service = profile->GetExtensionService();