Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/background_contents_service.cc

Issue 5968009: Change extension unload notification to indicate updates.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/automation/automation_extension_tracker.cc ('K') | « chrome/browser/background_application_list_model.cc ('k') | chrome/browser/background_mode_manager.cc » ('j') | chrome/browser/background_mode_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background_contents_service.cc
===================================================================
--- chrome/browser/background_contents_service.cc (revision 69996)
+++ chrome/browser/background_contents_service.cc (working copy)
@@ -115,7 +115,8 @@
break;
case NotificationType::EXTENSION_UNLOADED:
ShutdownAssociatedBackgroundContents(
- ASCIIToUTF16(Details<const Extension>(details)->id()));
+ ASCIIToUTF16(
+ Details<UnloadedExtensionInfo>(details)->extension->id()));
Erik does not do reviews 2010/12/23 17:05:17 extension can be NULL right? more reason why we s
asargent_no_longer_on_chrome 2010/12/23 18:53:04 It turns out it can't.
break;
default:
NOTREACHED();
« chrome/browser/automation/automation_extension_tracker.cc ('K') | « chrome/browser/background_application_list_model.cc ('k') | chrome/browser/background_mode_manager.cc » ('j') | chrome/browser/background_mode_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698